[PATCH] staging: media: atomisp: use kvmalloc_objs() in make_histogram()
Rodrigo Gobbi <[email protected]> Tue, 9 Jun 2026 18:46:31 -0300
| Newsgroups | dev.linux.lists.linux-kernel-mentees,dev.linux.lists.linux-staging,org.kernel.vger.linux-kernel,org.kernel.vger.linux-media |
|---|---|
| Message-ID | <[email protected]> |
Replace kvmalloc() with multiply with kvmalloc_objs(), which handles the size multiplication internally with overflow checking, silenting checkpatch warn. Signed-off-by: Rodrigo Gobbi <[email protected]> --- Hi, all, There is a ongoing effort like this for other files from atomisp at [1], yet, it is not covering the same file. Tks and regards. [1] https://lore.kernel.org/all/[email protected]/ --- drivers/staging/media/atomisp/pci/sh_css_metrics.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/sh_css_metrics.c b/drivers/staging/media/atomisp/pci/sh_css_metrics.c index edf473dd86ca..d3ae737f1764 100644 --- a/drivers/staging/media/atomisp/pci/sh_css_metrics.c +++ b/drivers/staging/media/atomisp/pci/sh_css_metrics.c @@ -59,16 +59,13 @@ make_histogram(struct sh_css_pc_histogram *histogram, unsigned int length) return; if (histogram->run) return; - histogram->run = kvmalloc(length * sizeof(*histogram->run), - GFP_KERNEL); + histogram->run = kvmalloc_objs(*histogram->run, length); if (!histogram->run) return; - histogram->stall = kvmalloc(length * sizeof(*histogram->stall), - GFP_KERNEL); + histogram->stall = kvmalloc_objs(*histogram->stall, length); if (!histogram->stall) return; - histogram->msink = kvmalloc(length * sizeof(*histogram->msink), - GFP_KERNEL); + histogram->msink = kvmalloc_objs(*histogram->msink, length); if (!histogram->msink) return; -- 2.48.1