[PATCH v3] staging: rtl8723bs: fix unnamed parameters warning detected at checkpatch
Rodrigo Gobbi <[email protected]> Tue, 9 Jun 2026 19:07:03 -0300
| Newsgroups | dev.linux.lists.linux-kernel-mentees,dev.linux.lists.linux-staging,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
Detected the following WARNING: function definition argument 'struct adapter *' should also have an identifier name. Add explicit names on those definitions. Signed-off-by: Rodrigo Gobbi <[email protected]> --- Hi, v2 was not applying anymore after a rebase, sending v3. Tks and regards. Changelog: v3: rebase; the rtl8723bs/include/rtw_btcoex.h from v2 is not needed anymore. v2: https://lore.kernel.org/all/[email protected]/ v1: https://lore.kernel.org/all/[email protected]/ --- drivers/staging/rtl8723bs/include/hal_intf.h | 2 +- drivers/staging/rtl8723bs/include/rtw_pwrctrl.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/include/hal_intf.h b/drivers/staging/rtl8723bs/include/hal_intf.h index ee8ad26325b5..8a85e8419e47 100644 --- a/drivers/staging/rtl8723bs/include/hal_intf.h +++ b/drivers/staging/rtl8723bs/include/hal_intf.h @@ -239,7 +239,7 @@ c2h_id_filter rtw_hal_c2h_id_filter_ccx(struct adapter *adapter); s32 rtw_hal_macid_sleep(struct adapter *padapter, u32 macid); s32 rtw_hal_macid_wakeup(struct adapter *padapter, u32 macid); -s32 rtw_hal_fill_h2c_cmd(struct adapter *, u8 ElementID, u32 CmdLen, u8 *pCmdBuffer); +s32 rtw_hal_fill_h2c_cmd(struct adapter *adapter, u8 ElementID, u32 CmdLen, u8 *pCmdBuffer); void SetHwReg8723BS(struct adapter *padapter, u8 variable, u8 *val); void GetHwReg8723BS(struct adapter *padapter, u8 variable, u8 *val); diff --git a/drivers/staging/rtl8723bs/include/rtw_pwrctrl.h b/drivers/staging/rtl8723bs/include/rtw_pwrctrl.h index 6977892a5742..c8592c4753c2 100644 --- a/drivers/staging/rtl8723bs/include/rtw_pwrctrl.h +++ b/drivers/staging/rtl8723bs/include/rtw_pwrctrl.h @@ -215,8 +215,8 @@ struct pwrctrl_priv { extern void rtw_init_pwrctrl_priv(struct adapter *adapter); extern void rtw_free_pwrctrl_priv(struct adapter *adapter); -s32 rtw_register_task_alive(struct adapter *, u32 task); -void rtw_unregister_task_alive(struct adapter *, u32 task); +s32 rtw_register_task_alive(struct adapter *adapter, u32 task); +void rtw_unregister_task_alive(struct adapter *adapter, u32 task); extern s32 rtw_register_tx_alive(struct adapter *padapter); extern void rtw_unregister_tx_alive(struct adapter *padapter); extern s32 rtw_register_cmd_alive(struct adapter *padapter); -- 2.48.1