Re: [PATCH v2] iio: chemical: ccs811: cleanup checkpatch __packed warning
David Lechner <[email protected]> Sun, 2 Aug 2026 10:14:32 -0500
| Newsgroups | dev.linux.lists.linux-kernel-mentees,org.kernel.vger.linux-iio,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On 8/1/26 9:25 PM, Adi Nata wrote: > Change instance of __attribute__((__packed__)) to __packed per > checkpatch.pl warning. > > Reported by checkpatch: > FILE: drivers/iio/chemical/ccs811.c This same feedback applies to all of the other patches you have been sending. Making checkpatch happy is not a good reason on it's own. Find out the reason why checkpatch makes this suggestion in the first place and use that as the justification for such changes. > > WARNING: Prefer __packed over __attribute__((__packed__)) > +} __attribute__((__packed__)); > > Signed-off-by: Adi Nata <[email protected]> > > v2: > - Rename commit message to include driver name > > --- > drivers/iio/chemical/ccs811.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/chemical/ccs811.c b/drivers/iio/chemical/ccs811.c > index ce7187ccd706..0e5c79b775a2 100644 > --- a/drivers/iio/chemical/ccs811.c > +++ b/drivers/iio/chemical/ccs811.c > @@ -70,7 +70,7 @@ struct ccs811_reading { > u8 status; > u8 error; > __be16 raw_data; > -} __attribute__((__packed__)); > +} __packed; > > struct ccs811_data { > struct i2c_client *client;