Re: [PATCH] arm64: dts: allwinner: a523: enable IR on the Avaota A1
| Newsgroups | dev.linux.lists.linux-sunxi,org.kernel.vger.linux-devicetree |
|---|---|
| Message-ID | <[email protected]> |
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] Device tree compilation fails due to an unresolved reference to the `&ir` node label. -- --- Patch [1]: [PATCH] arm64: dts: allwinner: a523: enable IR on the Avaota A1 --- commit 357c50b8a0f2e8f0f484a1872fb40899f5baa624 Author: Andre Przywara <[email protected]> arm64: dts: allwinner: a523: enable IR on the Avaota A1 This commit adds the IR receiver pin description to the PIO DT node and enables the CIR receiver in the main power domain for the Avaota A1 board. > diff --git a/arch/arm64/boot/dts/allwinner/sun55i-t527-avaota-a1.dts b/arch/arm64/boot/dts/allwinner/sun55i-t527-avaota-a1.dts > --- a/arch/arm64/boot/dts/allwinner/sun55i-t527-avaota-a1.dts > +++ b/arch/arm64/boot/dts/allwinner/sun55i-t527-avaota-a1.dts [ ... ] > @@ -100,6 +100,12 @@ &gpu { > status = "okay"; > }; > > +&ir { > + pinctrl-names = "default"; > + pinctrl-0 = <&ir_rx_pin>; > + status = "okay"; > +}; > + [Severity: Low] Does this node extension cause a build failure when compiling the device tree? It looks like the &ir label is not defined in the base sun55i-a523.dtsi file or any of its dependencies, which would cause dtc to fail with an unresolved reference error. The commit message notes that this patch goes on top of another IR receiver series. Should that base dependency be merged first to ensure the build remains unbroken? -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1