Re: [PATCH v4 4/5] tools/memory-model: Switch to softcoded herd7 tags

Am 10/29/2024 um 1:04 AM schrieb Boqun Feng:
>
> One bit below:
 >
> On Mon, Sep 30, 2024 at 12:57:09PM +0200, Jonas Oberhauser wrote:
>>       ------------------------------------------------------------------------------
>>       |       RMW ops w/o return value |                                           |
>>       ------------------------------------------------------------------------------
>> -    |                     atomic_add | R*[noreturn] ->rmw W*[once]               |
>> +    |                     atomic_add | R*[noreturn] ->rmw W*[noreturn]           |
> 
> Not in this patch, but don't you need to update this again to all cap
> to match your changes in patch #5? ;-)
> 

Hmmm, probably that is a good idea.
I actually had thought about it for some of the other places in the doc 
that mention the tags, and concluded that we'll just use the semantic 
tags there.

But in fact, this file is about the syntactic representation in herd, 
and there is no noreturn semantic tag on the W*, so it wouldn't match it 
even if it were correct.

So I think this needs to be addressed in 5/5.


   jonas