Re: [PATCH net-next v2 2/8] dt-bindings: mfd: x-powers: add AC200

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The binding omits required properties for the hardware's interrupt controller capability.
- [Low] The commit message description is not capitalized, violating the MFD subsystem guidelines.
--

--- Patch [2]: [PATCH net-next v2 2/8] dt-bindings: mfd: x-powers: add AC200 ---
commit 5fdfa30c4c35094fa0d906393ce55eb7a91506b0
Author: James Hilliard <[email protected]>

dt-bindings: mfd: x-powers: add AC200

This commit introduces the device tree binding for the X-Powers AC200
mixed-signal companion IC. It describes the parent device, its input clocks,
supplies, and an optional Ethernet PHY control child.

> dt-bindings: mfd: x-powers: add AC200

[Severity: Low]
This isn't a bug, but should the description after the subsystem prefix be
capitalized? The MFD subsystem conventions generally expect a capitalized
description like "Add AC200".

> diff --git a/Documentation/devicetree/bindings/mfd/x-powers,ac200.yaml b/Documentation/devicetree/bindings/mfd/x-powers,ac200.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/x-powers,ac200.yaml

[ ... ]

> +  ethernet-phy-control:
> +    $ref: /schemas/net/x-powers,ac200-ephy-ctl.yaml#
> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - ac-ldoin-supply
> +  - ephy-vcc-supply
> +  - rtc-vcc-supply
> +  - tv-vcc-supply

[Severity: Medium]
The commit message notes that interrupt-controller properties can be added
later with the child functions that consume them. Does omitting these
properties from the required list allow incomplete device tree nodes to
silently pass schema validation?

Since the hardware has interrupt controller capabilities, should
interrupt-controller and #interrupt-cells be defined and added to the
required list now? This would prevent situations where future drivers attempt
to use the interrupts and fail on device trees that passed this initial schema.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2