Re: [PATCH net-next v2 1/8] dt-bindings: net: x-powers: add AC200 EPHY control

[email protected] Thu, 06 Aug 2026 02:32:38 +0000
Newsgroups dev.linux.lists.mfd,org.kernel.vger.linux-devicetree
Message-ID <[email protected]>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The YAML binding schema is missing the mandatory `examples:` section.
--

--- Patch [1]: [PATCH net-next v2 1/8] dt-bindings: net: x-powers: add AC200 EPHY control ---
commit e7e7a5a68f157d374c9eb4fdb6add2b0b9d23284
Author: James Hilliard <[email protected]>

dt-bindings: net: x-powers: add AC200 EPHY control

This commit adds the device tree binding for the X-Powers AC200 Fast Ethernet
PHY control function. It describes the control logic and an optional SoC SID
calibration cell used by the AC200 I2C regmap.

> diff --git a/Documentation/devicetree/bindings/net/x-powers,ac200-ephy-ctl.yaml b/Documentation/devicetree/bindings/net/x-powers,ac200-ephy-ctl.yaml
> new file mode 100644
> index 0000000000000..5bb60542030fc
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/x-powers,ac200-ephy-ctl.yaml

[ ... ]

> required:
>   - compatible
> 
> dependentRequired:
>   nvmem-cells: [ nvmem-cell-names ]
> 
> additionalProperties: false
> ...

[Severity: Low]
Is this YAML binding schema missing the examples section? 

Device tree bindings typically require an examples section at the end of the
document. Without it, developers lack documentation on how to construct the
node, and the dt_binding_check tooling has no concrete representation to
validate the schema against to ensure constraints like dependentRequired work
as intended.

-- 
Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=1