Re: [PATCH] dt-bindings: mfd: ti,keystone-devctrl: Convert to DT schema

On Thu, Aug 13, 2026 at 10:24:12PM +0530, Bhargav Joshi wrote:
> On Thu, Aug 13, 2026 at 10:11 PM <[email protected]> wrote:
> >
> > Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
> > - [Medium] The schema enforces non-compliant, legacy device tree node names (containing underscores) for child nodes via `patternProperties`, blocking the use of standard generic names and contradicting the commit message.
> Yes nodes with underscores are kept not to break older dts/dtsi files
> which uses underscores

No, you made them ABI now without explanation why this is needed.

> > - [Low] The YAML example references undefined phandles (`&devctrl` and `&pllctrl`), which will cause a fatal `dtc` compilation error during `make dt_binding_check`.
> no this won't cause any errors related to references ( tested on version 2026.7)
> > --
> >
> > --- Patch [1]: [PATCH] dt-bindings: mfd: ti,keystone-devctrl: Convert to DT schema ---
> > commit f59b6bface010fc243ef7f899dbb8dddf737e2c5
> > Author: Bhargav Joshi <[email protected]>
> >
> > dt-bindings: mfd: ti,keystone-devctrl: Convert to DT schema
> >
> > Converts the Texas Instruments Keystone Device State Control binding from
> > legacy text format to DT schema. Adds "simple-mfd" support, enforces child
> > bus properties, and adds validations for standard child nodes.

What is the last sentence about? Changes during conversion or explaining
basics of binding?

Best regards,
Krzysztof