Re: [PATCH] dt-bindings: mfd: ti,keystone-devctrl: Convert to DT schema

Krzysztof Kozlowski <[email protected]>
Newsgroups dev.linux.lists.mfd,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel
Message-ID <20260814-brilliant-real-moose-e4158c@quoll>
On Thu, Aug 13, 2026 at 10:03:53PM +0530, Bhargav Joshi wrote:
> Convert the Texas Instruments Keystone Device State Control binding from
> legacy text format to DT schema.
> 
> During the conversion, the following updates were made:
> - Added "simple-mfd" to the allowed compatible strings.
> - Enforced child bus properties (#address-cells, #size-cells, and ranges)
>   to be required only when the "simple-mfd" compatible is present.
> - Added patternProperties definitions to validate standard child nodes
> - Updated the examples to demonstrate simple-mfd parent usage and updated
>   node names to conform with standard Devicetree specifications.
> 
> Signed-off-by: Bhargav Joshi <[email protected]>
> ---
> Note:
> Running dt_binding_check on patch will yield a warning for
> 'ti,keystone-reset' in the example block. The YAML conversion patch
> for that child node is already in progress here:
> https://lore.kernel.org/linux-devicetree/[email protected]/
> ---
>  .../bindings/mfd/ti,keystone-devctrl.yaml          | 105 +++++++++++++++++++++
>  .../bindings/mfd/ti-keystone-devctrl.txt           |  19 ----
>  2 files changed, 105 insertions(+), 19 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/ti,keystone-devctrl.yaml b/Documentation/devicetree/bindings/mfd/ti,keystone-devctrl.yaml
> new file mode 100644
> index 000000000000..33a72c290fb1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/ti,keystone-devctrl.yaml
> @@ -0,0 +1,105 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mfd/ti,keystone-devctrl.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Texas Instruments Keystone Device State Control
> +
> +maintainers:
> +  - Ivan Khoronzhuk <[email protected]>
> +
> +description:
> +  The Keystone II devices have a set of registers that are used to control the
> +  status of its peripherals. This node is intended to allow access to this
> +  functionality.
> +
> +properties:
> +  compatible:
> +    minItems: 2

Why? Where is it explained in commit msg?

> +    items:
> +      - const: ti,keystone-devctrl
> +      - const: syscon
> +      - const: simple-mfd
> +
> +  reg:
> +    maxItems: 1
> +
> +  "#address-cells":
> +    const: 1
> +
> +  "#size-cells":
> +    const: 1
> +
> +  ranges: true
> +
> +patternProperties:
> +  "^keystone_dsp_gpio@[0-9a-f]+$":


Incorrect names added without explanation.

Best regards,
Krzysztof
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.