Re: [PATCH v2 01/10] dt-bindings: mfd: common ROHM PMIC properties

On Tue, Aug 4, 2026 at 12:20 PM Matti Vaittinen
<[email protected]> wrote:

> From: Matti Vaittinen <[email protected]>
>
> ROHM PMICs keep having similar functionalities from one generation to the
> next. Keeping the device-trees describing these functionalities similar
> helps users because:
>   1. They can re-use existing device-tree properties when switching from
>      one project, using a ROHM PMIC, to next project using newer
>      variant.
>   2. The users can find and re-use examples from old projects - even if
>      they never worked with ROHM PMICs before.
> Similarly, introducing new and different properties for same
> functionality previous variant had, will be adding confusion.
>
> Sometimes the existing properties aren't 100% what reviewers would
> prefer. When issues are minor or just cosmetic, changing the existing
> properties is not feasible. Reviewers can't be expected to know which
> properties are new, and which are existing - and this can lead to
> unnecessary review discussion wasting time and energy from everyone.
>
> Adding a common file for re-used ROHM PMIC properties should make it
> clearly visible that a property is re-used, when a new PMIC binding
> refers to this file instead of (re-)describing all the existing
> bindings. This will also help keeping the common properties identical
> across the variants.
>
> Add new file listing commonly used ROHM PMIC properties.
>
> Signed-off-by: Matti Vaittinen <[email protected]>

DT maintainers think it's fine in two patches so:
Reviewed-by: Linus Walleij <[email protected]>

Yours,
Linus Walleij