Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Unresolved phandle references in the YAML example cause `dt_binding_check` failures.
--
--- Patch [2]: [PATCH v2 2/2] dt-bindings: mfd: ti,keystone-devctrl: Convert to DT schema ---
commit 48184e73993f7287e1c95f939a5d488075736de6
Author: Bhargav Joshi <[email protected]>
dt-bindings: mfd: ti,keystone-devctrl: Convert to DT schema
This commit converts the Texas Instruments Keystone Device State Control
binding from the legacy text format to a DT schema. It also adds simple-mfd
and missing bus properties while documenting child nodes.
> diff --git a/Documentation/devicetree/bindings/mfd/ti,keystone-devctrl.yaml b/Documentation/devicetree/bindings/mfd/ti,keystone-devctrl.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/ti,keystone-devctrl.yaml
[ ... ]
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> + device-state-control@2620000 {
> + compatible = "ti,keystone-devctrl", "syscon", "simple-mfd";
> + reg = <0x02620000 0x1000>;
[ ... ]
> + interrupt-controller@2a0 {
> + compatible = "ti,keystone-irq";
> + reg = <0x2a0 0x4>;
> + interrupts = <GIC_SPI 4 IRQ_TYPE_EDGE_RISING>;
> + interrupt-controller;
> + #interrupt-cells = <1>;
> + ti,syscon-dev = <&devctrl 0x2a0>;
[Severity: Low]
Will dtc fail to compile this example due to an unresolved phandle reference?
The previous text binding defined a devctrl: label for the parent node, but
it appears to have been dropped during the conversion.
> + };
> +
> + reset-controller@328 {
> + compatible = "ti,keystone-reset";
> + reg = <0x328 0x10>;
> + ti,syscon-pll = <&pllctrl 0xe4>;
[Severity: Low]
Does the example need a dummy pllctrl node or label to avoid validation
failures? It looks like &pllctrl is referenced here but not defined anywhere
in the example block.
> + ti,syscon-dev = <&devctrl 0x328>;
> + ti,wdt-list = <0>;
> + };
> + };
--
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2
lmpx.com only provides a reader for public news (NNTP) servers. It is not
affiliated with the servers or forums shown here and is not responsible for
the content of articles, which is written by their respective authors.