Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Renaming the user-visible Kconfig symbol `MFD_NCT6694` to `MFD_NCT6694_USB` without a migration path silently drops the driver from existing kernel configurations.
--
--- Patch [4]: [PATCH v7 04/10] mfd: nct6694: Rename driver to nct6694-usb and update Kconfig ---
commit 215b54ed65ccbd40b44ec465fcadf580136e0e2d
Author: Ming Yu <[email protected]>
mfd: nct6694: Rename driver to nct6694-usb and update Kconfig
This commit renames the nct6694 driver to nct6694-usb to reflect its USB
transport backend. It also introduces the MFD_NCT6694_USB option and hides
the original MFD_NCT6694 config, setting it up to be selected by transport
drivers.
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 763ce6a34782b..5506a0adf3ec0 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -1164,19 +1164,30 @@ config MFD_MENF21BMC
> will be called menf21bmc.
>
> config MFD_NCT6694
> - tristate "Nuvoton NCT6694 support"
> + tristate
> select MFD_CORE
[Severity: Medium]
Will users upgrading their kernel with an existing .config have the NCT6694
driver silently disabled?
The original symbol loses its prompt here, making it hidden. Because the new
MFD_NCT6694_USB symbol has no default fallback or migration mechanism, it looks
like running `make olddefconfig` with CONFIG_MFD_NCT6694=y will drop the
driver entirely.
Does it make sense to add a default property to MFD_NCT6694_USB to migrate the
previous configuration?
> + help
> + Core MFD support for the Nuvoton NCT6694 peripheral expander.
[ ... ]
> +config MFD_NCT6694_USB
> + tristate "Nuvoton NCT6694 USB interface support"
> + select MFD_NCT6694
> depends on USB
--
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=4
lmpx.com only provides a reader for public news (NNTP) servers. It is not
affiliated with the servers or forums shown here and is not responsible for
the content of articles, which is written by their respective authors.