Re: [PATCH v2 03/10] dt-bindings: regulator: ROHM BD73800 regulators

"Rob Herring (Arm)" <[email protected]> Tue, 04 Aug 2026 07:31:30 -0500
Newsgroups dev.linux.lists.mfd,org.kernel.vger.linux-clk,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-gpio,org.kernel.vger.linux-kernel,org.kernel.vger.linux-rtc
Message-ID <[email protected]>
On Tue, 04 Aug 2026 13:21:14 +0300, Matti Vaittinen wrote:
> From: Matti Vaittinen <[email protected]>
> 
> Add bindings for the BUCKs and LDOs on ROHM BD73800. The PMIC state
> specific voltages can be set in same fashion as with a few other ROHM
> PMICs (for example with BD718[15,28,37,47,50,79]). Same properties are
> recycled :)
> 
> The LDOs 1 and 4 can use different voltage ranges depending on the OTP
> configuration.
> 
> Signed-off-by: Matti Vaittinen <[email protected]>
> 
> ---
> Revision history:
> v1 => v2:
>  - Description of the state specific voltages moved to own file and
>    referenced from it (because multiple PMIC bindings used them).
> 
> The dt checker's documentation reference checker warns about the link to
> the MFD binding - which will be introduced in next commit. These commits
> have kind of a chicken and egg issue as MFD is referencing regulator
> properties introduced in this patch.
> 
> I could squash these but IMO, this is clearer for the reviewers. AFAICS,
> Both MFD and regulator subsystems tend to be busy. I could also split
> adding the MFD comment reference to own patch which would be after the
> patch adding the MFD binding, but having own patch for just adding the
> comment is a bit meh.
> 
> So, I decided to live with the broken doc-link between these two
> patches.
> ---
>  .../regulator/rohm,bd73800-regulator.yaml     | 99 +++++++++++++++++++
>  1 file changed, 99 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/regulator/rohm,bd73800-regulator.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/regulator/rohm,bd73800-regulator.yaml: Unresolvable reference: rohm,pmic-states.yaml#

doc reference errors (make refcheckdocs):
Warning: Documentation/devicetree/bindings/regulator/rohm,bd73800-regulator.yaml references a file that doesn't exist: Documentation/devicetree/bindings/mfd/rohm,bd73800-pmic.yaml
Documentation/devicetree/bindings/regulator/rohm,bd73800-regulator.yaml: Documentation/devicetree/bindings/mfd/rohm,bd73800-pmic.yaml

See https://patchwork.kernel.org/project/devicetree/patch/e1ada83ee4bdc1d1718fa81c335c741771ab57c3.1785838585.git.mazziesaccount@gmail.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.