Re: [PATCH v2 5/8] nvmet: pci-epf: Remove unnecessary dmaengine_terminate_sync() on each DMA transfer
Damien Le Moal <[email protected]>
| Newsgroups | dev.linux.lists.mhi,dev.linux.lists.imx,org.infradead.lists.linux-arm-kernel,org.infradead.lists.linux-nvme,org.kernel.vger.dmaengine,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-crypto,org.kernel.vger.linux-kernel,org.kernel.vger.linux-pci |
|---|---|
| Organization | Western Digital Research |
| Message-ID | <[email protected]> |
On 12/19/25 00:56, Frank Li wrote: > dmaengine_terminate_sync() cancels all pending requests. Calling it for > every DMA transfer is unnecessary and counterproductive. This function is > generally intended for cleanup paths such as module removal, device close, > or unbind operations. > > Remove the redundant calls for success path and keep it only at error path. > > Tested-by: Niklas Cassel <[email protected]> > Signed-off-by: Frank Li <[email protected]> Looks good. Reviewed-by: Damien Le Moal <[email protected]> -- Damien Le Moal Western Digital Research