[PATCH v3 0/2] gpu: nova: fix incorrect GSP barrier usage
Gary Guo <[email protected]>
| Newsgroups | dev.linux.lists.nova-gpu,org.freedesktop.lists.dri-devel,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
Currently Nova GSP code uses Rust barriers, which equivalent to LKMM SMP barriers. This does not provide sufficient ordering for DMA operations on AArch64. Fix this to be using the newly introduced `dma_mb(Ordering)` API. Also, there is an incorrect placement of barrier, which is also fixed. This should wait until v7.3-rc1 backmerge to drm-rust-next occurs. --- Changes in v3: - Drop abstraction changes which are already picked. - Improve ordering comment messages. - Replace control dependency reliance with explicit barrier. - Link to v2: https://patch.msgid.link/[email protected] Changes in v2: - Dropped `Acquire` and `Release` aliases of `Full` (Joel) - Use macros to implement most `MemoryBarrier` - Split Nova change to GSP->CPU commit and CPU->GSP commit (Joel) - Link to v1: https://patch.msgid.link/[email protected] To: Danilo Krummrich <[email protected]> To: Alice Ryhl <[email protected]> To: Alexandre Courbot <[email protected]> To: David Airlie <[email protected]> To: Simona Vetter <[email protected]> Cc: [email protected] Cc: [email protected] Cc: [email protected] --- Gary Guo (2): gpu: nova-core: fix barrier usage in CPU->GSP messaging path gpu: nova-core: fix barrier usage in GSP->CPU messaging path drivers/gpu/nova-core/gsp/cmdq.rs | 34 ++++++++++++++++++++-------------- 1 file changed, 20 insertions(+), 14 deletions(-) --- base-commit: e6664f2b33db9b6811eb4cec109f06cb2b4f458d change-id: 20260609-rust-barrier-63078ea76216 Best regards, -- Gary Guo <[email protected]>