Re: [PATCH 03/10] qnx4: handle set_blocksize failures
Christoph Hellwig <[email protected]> Mon, 11 May 2026 09:45:56 +0200
| Newsgroups | dev.linux.lists.ntfs3,org.kernel.vger.linux-fsdevel |
|---|---|
| Message-ID | <[email protected]> |
On Mon, May 11, 2026 at 09:42:49AM +0200, Anders Larsen wrote: > Hi, > > On 2026-05-11 09:16 Christoph Hellwig wrote: > > qnx4 uses buffer_heads, which don't handle block size > PAGE_SIZE well. > > qnx4fs uses a fixed block size of 512 bytes, so this will never happen. > > > - sb_set_blocksize(s, QNX4_BLOCK_SIZE); > > + if (!sb_set_blocksize(s, QNX4_BLOCK_SIZE)) > > + return -EINVAL; > > QNX4_BLOCK_SIZE is a constant (512)... Yes, which means that sb_set_blocksize fails when the device has an LBA size larger than 512 bytes, and this failure should be handled.