Re: [PATCH 03/10] qnx4: handle set_blocksize failures

Anders Larsen <[email protected]> Mon, 11 May 2026 09:42:49 +0200
Newsgroups dev.linux.lists.ntfs3,org.kernel.vger.linux-fsdevel
Message-ID <12893675.O9o76ZdvQC@oscar>
Hi,

On 2026-05-11 09:16 Christoph Hellwig wrote:
> qnx4 uses buffer_heads, which don't handle block size > PAGE_SIZE well.

qnx4fs uses a fixed block size of 512 bytes, so this will never happen.

> -	sb_set_blocksize(s, QNX4_BLOCK_SIZE);
> +	if (!sb_set_blocksize(s, QNX4_BLOCK_SIZE))
> +		return -EINVAL;

QNX4_BLOCK_SIZE is a constant (512)...

Cheers
Anders