Re: [PATCH 03/10] qnx4: handle set_blocksize failures
Anders Larsen <[email protected]> Mon, 11 May 2026 10:20:05 +0200
| Newsgroups | dev.linux.lists.ntfs3,org.kernel.vger.linux-fsdevel |
|---|---|
| Message-ID | <5102053.31r3eYUQgx@oscar> |
On 2026-05-11 09:45 Christoph Hellwig wrote: > On Mon, May 11, 2026 at 09:42:49AM +0200, Anders Larsen wrote: > > On 2026-05-11 09:16 Christoph Hellwig wrote: > > > qnx4 uses buffer_heads, which don't handle block size > PAGE_SIZE well. > > > > qnx4fs uses a fixed block size of 512 bytes, so this will never happen. > > > > > - sb_set_blocksize(s, QNX4_BLOCK_SIZE); > > > + if (!sb_set_blocksize(s, QNX4_BLOCK_SIZE)) > > > + return -EINVAL; > > > > QNX4_BLOCK_SIZE is a constant (512)... > > Yes, which means that sb_set_blocksize fails when the device has an LBA > size larger than 512 bytes, and this failure should be handled. OK, so I misunderstood the issue. In that case: Acked-by: Anders Larsen <[email protected]>