Re: [PATCH v2 2/2] arm64: dts: qcom: sdm845-shift-axolotl: Enable NFC
Konrad Dybcio <[email protected]> Tue, 24 Mar 2026 14:12:53 +0100
| Newsgroups | dev.linux.lists.oe-linux-nfc,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.kernel.vger.netdev,org.kernel.vger.phone-devel |
|---|---|
| Message-ID | <[email protected]> |
On 3/24/26 12:20 AM, David Heidelberg via B4 Relay wrote: > From: David Heidelberg <[email protected]> > > Definition of the NFC. "meh" commit message [...] > + nfc_enable_default: nfc-enable-default-state { > + pins = "gpio12", "gpio62"; > + function = "gpio"; > + drive-strength = <2>; > + bias-pull-up; Are you sure about pulling up an active-high pin? FWIW TLMM subnodes are best sorted by pin index (although the file currently doesn't really do that) as per dts coding style Konrad