Re: [PATCH v2 2/2] arm64: dts: qcom: sdm845-shift-axolotl: Enable NFC

David Heidelberg <[email protected]> Tue, 24 Mar 2026 19:08:15 +0100

Newsgroups	dev.linux.lists.oe-linux-nfc,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.kernel.vger.netdev,org.kernel.vger.phone-devel
Message-ID	<[email protected]>

On 24/03/2026 14:12, Konrad Dybcio wrote:
> On 3/24/26 12:20 AM, David Heidelberg via B4 Relay wrote:
>> From: David Heidelberg <[email protected]>
>>
>> Definition of the NFC.
> 
> "meh" commit message
> 
> [...]
> 
>> +	nfc_enable_default: nfc-enable-default-state {
>> +		pins = "gpio12", "gpio62";
>> +		function = "gpio";
>> +		drive-strength = <2>;
>> +		bias-pull-up;
> 
> Are you sure about pulling up an active-high pin?

I'm not sure, but downstream does it (and "works for me"). Maybe Alexander would 
know more details here.

David

> 
> FWIW TLMM subnodes are best sorted by pin index (although the file
> currently doesn't really do that) as per dts coding style

I assume when I group the -pins into -state it doesn't apply anymore? As I don't 
feel having pins relevant to one device / subsystem all over the place is extra 
clean.

David

P.S. before v3 code is here
https://codeberg.org/sdm845/linux/commits/branch/b4/oneplus-nfc

> 
> Konrad

-- 
David Heidelberg