Re: [v3 0/1] Unnecessary code cleanup patches
Samuel Abraham <[email protected]> Sat, 5 Apr 2025 12:15:39 +0100
| Newsgroups | dev.linux.lists.outreachy,dev.linux.lists.linux-staging,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <CADYq+fZyKSGihR8YbAXbGii9YCy9CG1UcLQUHhD0S7ifsesu-Q@mail.gmail.com> |
On Sat, Apr 5, 2025 at 9:37 AM Greg KH <[email protected]> wrote: > > On Fri, Apr 04, 2025 at 01:02:19AM +0100, Abraham Samuel Adekunle wrote: > > The patchset modifies unnecessary duplicate NULL test on a > > value in an expression, when the value has been NULL tested in a > > previous expression. > > Nit, the subject line does nto have "staging:" in it, so I don't know > where this goes. > > Also, it really reads as "this is an unnecessary patch" :) Argh, Not what I meant to say at all :) Thank you. > > And finally, for a single patch, there's usually not a need for a 0/X > email to describe it, everything should be in just the single patch > itself. It initially started as a patchset with modification for three different drivers, one patch for each driver, but two were dropped from the patchset for being media drivers. So I thought I should add the cover letter to the only patch left in the patchset so details about the changes can be made known. I've made a note of this. Thanks. Adekunle.