Re: [PATCH v8 0/2] staging: rtl8723bs: Improve readability and clarity of sequence number wrapping

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1061154757-1744164718=:4262
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT



On Tue, 8 Apr 2025, Samuel Abraham wrote:

> On Tue, Apr 8, 2025 at 8:41 PM Andy Shevchenko <[email protected]> wrote:
> >
> > On Tue, Apr 08, 2025 at 03:41:55PM +0000, Abraham Samuel Adekunle wrote:
> > > The patchset adds spaces around binary operators, breaks long lines to enhance readability
> > > and provides clarity on sequence number wrapping by using a modulo operation % 4096u, in
> > > place of the bitwise AND(&) operation & 0xfff.
> > > The patches are required to be applied in sequence.
> >
> > You missed my tags I gave in a previous review round.
>
> Oh, I'm sorry I do not know how that works, please.
> Am I supposed to add them to the commit message?

Yes.

julia

> >
> > --
> > With Best Regards,
> > Andy Shevchenko
> >
> >
> >
>
--8323329-1061154757-1744164718=:4262--