Re: [PATCH v8 0/2] staging: rtl8723bs: Improve readability and clarity of sequence number wrapping

Samuel Abraham <[email protected]> Wed, 9 Apr 2025 09:53:11 +0100

Newsgroups	dev.linux.lists.outreachy,dev.linux.lists.linux-staging,org.kernel.vger.linux-kernel
Message-ID	<CADYq+fYQHtiQU71w4-4V2Rts7mEHVxLEYbxJp7LnCQQAoxycqw@mail.gmail.com>

On Wed, Apr 9, 2025 at 3:11=E2=80=AFAM Julia Lawall <[email protected]>=
 wrote:
>
>
>
> On Tue, 8 Apr 2025, Samuel Abraham wrote:
>
> > On Tue, Apr 8, 2025 at 8:41=E2=80=AFPM Andy Shevchenko <[email protected]=
> wrote:
> > >
> > > On Tue, Apr 08, 2025 at 03:41:55PM +0000, Abraham Samuel Adekunle wro=
te:
> > > > The patchset adds spaces around binary operators, breaks long lines=
 to enhance readability
> > > > and provides clarity on sequence number wrapping by using a modulo =
operation % 4096u, in
> > > > place of the bitwise AND(&) operation & 0xfff.
> > > > The patches are required to be applied in sequence.
> > >
> > > You missed my tags I gave in a previous review round.
> >
> > Oh, I'm sorry I do not know how that works, please.
> > Am I supposed to add them to the commit message?
>
> Yes.

Hello Julia.
Thanks for the clarity

Adekunle