Re: [Powertop] [Warning fixes 1/6] if 0/endif out unused function dbg_printf_pevent_info

On (08/24/12 18:48), Joerg Mayer wrote:
> Is someone intending to use it or should it be removed instead?
> 
> Signed-off-by: Joerg Mayer <jmpt(a)loplof.de>
> 
> diff --git a/src/process/do_process.cpp b/src/process/do_process.cpp
> index cb7c672..3db5331 100644
> --- a/src/process/do_process.cpp
> +++ b/src/process/do_process.cpp
> @@ -186,6 +186,7 @@ int dont_blame_me(char *comm)
>  	return 0;
>  }
>  
> +#if 0
>  static void dbg_printf_pevent_info(struct event_format *event, struct pevent_record *rec)
>  {
>  	static struct trace_seq s;
> @@ -198,6 +199,7 @@ static void dbg_printf_pevent_info(struct event_format *event, struct pevent_rec
>  	fprintf(stderr, "%.*s", s.len, s.buffer);
>  	trace_seq_destroy(&s);
>  }
> +#endif
>  
>  static char * get_pevent_field_str(void *trace, struct event_format *event, struct format_field *field)
>  {
> -- 

This one could be helpful for debugging. Let's remove it, since the appropriate place
for this sort of routines is within pevent, to my mind.


	-ss