Re: [Powertop] [PATCH] Fix screen DPMS support detection

Igor Zhbanov <i.zhbanov at samsung.com> Mon, 13 Aug 2012 20:52:28 +0400
Newsgroups dev.linux.lists.powertop
Message-ID <[email protected]>
Hi Arjan,

Please look at my next patch too. I try to get rid of things like:
-2147483648%, "Display backlight",

The problem is that on some architectures max_brightness is 0. And you 
can find
division by zero and getting NaNs in backlight code. So I try to fix it 
not to use incorrect
values when DPMS is disabled or backlight control is not supported.

Arjan van de Ven wrote:
> On 8/13/2012 9:41 AM, Igor Zhbanov wrote:
>> Consider DPMS disabled when we can't open /sys/class/drm/card0 directory.
> if you don't have a graphics card with proper driver...
> there's nothing we can do and pretending that DPMS is disabled sounds like a mostly bad idea
> on first sight
>
> what is behind the idea of assuming it disabled ???
>
>
> _______________________________________________
> PowerTop mailing list
> PowerTop(a)lists.01.org
> https://lists.01.org/mailman/listinfo/powertop
>


-- 
Best regards,
Igor Zhbanov,
Expert Software Engineer,
phone: +7 (495) 797 25 00 ext 3806
e-mail: i.zhbanov(a)samsung.com

ASWG, Moscow R&D center, Samsung Electronics
12 Dvintsev street, building 1
127018, Moscow, Russian Federation