Re: [PATCH v3 1/3] dt-bindings: platform: introduce EC for Dell XPS 13 9345

On Saturday, August 1st, 2026 at 20:32, [email protected] <sashiko-bot=
@kernel.org> wrote:

> Thank you for your contribution! Sashiko AI review found 1 potential issu=
e(s) to consider:
> - [Low] The device tree binding example includes a nonexistent header and=
 uses undefined parameterized macros, breaking schema validation.
> --
>=20
> --- Patch [1]: [PATCH v3 1/3] dt-bindings: platform: introduce EC for Del=
l XPS 13 9345 ---
> commit 260bc940f745039b1b740f5fca09f58549473355
> Author: Aleksandrs Vinarskis <[email protected]>
>=20
> dt-bindings: platform: introduce EC for Dell XPS 13 9345
>=20
> Add bindings for Embedded Controller (EC) in Dell XPS 13 9345 (platform
> codename 'tributo'). It may be partially or fully compatible with EC
> found in Snapdragon-based Dell Latitude, Inspiron ('thena').
>=20
> > diff --git a/Documentation/devicetree/bindings/embedded-controller/dell=
,xps13-9345-ec.yaml b/Documentation/devicetree/bindings/embedded-controller=
/dell,xps13-9345-ec.yaml
> > new file mode 100644
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/embedded-controller/dell,xps13-=
9345-ec.yaml
>=20
> [ ... ]
>=20
> > +examples:
> > +  - |
> > +    #include <dt-bindings/interrupt-controller/irq.h>
> > +    #include <arm64/qcom/qcom-adc5-gen3.h>
>                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

It exist in linux-next, namely next-2026031, as per series dependency.

>=20
> [Severity: Low]
> Does this header exist in the source tree? It appears to be missing, whic=
h
> would cause a fatal preprocessor error during schema validation when runn=
ing
> make dt_binding_check.
>=20
> > +    i2c {
> > +        #address-cells =3D <1>;
> > +        #size-cells =3D <0>;
> > +
> > +        embedded-controller@3b {
> > +            compatible =3D "dell,xps13-9345-ec";
> > +            reg =3D <0x3b>;
> > +            interrupts-extended =3D <&tlmm 66 IRQ_TYPE_LEVEL_LOW>;
> > +
> > +            io-channels =3D <&pmk8550_vadc ADC5_GEN3_AMUX3_GPIO_100K_P=
U(1)>,
>                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^=
^
>=20
> [Severity: Low]
> Are these macros defined anywhere? They appear to be undefined and used
> incorrectly as parameterized macros, which would further contribute to
> preprocessor and schema check errors.

Exists in the import above. Confirmed to pass with:
`make dt_binding_check DT_SCHEMA_FILES=3Ddell,xps13-9345-ec.yaml`

Alex

>=20
> --
> Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260801-dell-xps=
[email protected]?part=3D1
>