Re: [PATCH v3 3/3] arm64: dts: qcom: x1e80100-dell-xps13-9345: introduce EC

On Saturday, August 1st, 2026 at 20:43, [email protected] <sashiko-bot=
@kernel.org> wrote:

> Thank you for your contribution! Sashiko AI review found 2 potential issu=
e(s) to consider:
> - [Low] The device tree patch extends and references a non-existent label=
 `pmk8550_vadc`, which will cause a fatal `dtc` compilation error.
> - [Low] The patch uses undefined function-like macros (e.g., `ADC5_GEN3_A=
MUX3_GPIO_100K_PU(1)`), which will cause a syntax error during device tree =
compilation.
> --
>=20
> --- Patch [3]: [PATCH v3 3/3] arm64: dts: qcom: x1e80100-dell-xps13-9345:=
 introduce EC ---
> commit e7703c5dfab63d67ae0d89c48a05547baa5abd7f
> Author: Aleksandrs Vinarskis <[email protected]>
>=20
> arm64: dts: qcom: x1e80100-dell-xps13-9345: introduce EC
>=20
> Describe embedded controller, its interrupt and required thermal zones.
> Add EC's reset GPIO to reserved range, as triggering it during device
> operation leads to unrecoverable and unusable state.
>=20
> > diff --git a/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts b/ar=
ch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts
> > index ce7b10ea89b6d..8d8d8014049bb 100644
> > --- a/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts
> > +++ b/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts
> [ ... ]
> > @@ -759,8 +759,32 @@ retimer_ss0_con_sbu_out: endpoint {
> [ ... ]
> > +=09embedded-controller@3b {
> > +=09=09compatible =3D "dell,xps13-9345-ec";
> > +=09=09reg =3D <0x3b>;
> > +
> > +=09=09interrupts-extended =3D <&tlmm 66 IRQ_TYPE_LEVEL_LOW>;
> > +
> > +=09=09pinctrl-0 =3D <&ec_int_n_default>;
> > +=09=09pinctrl-names =3D "default";
> > +
> > +=09=09io-channels =3D <&pmk8550_vadc ADC5_GEN3_AMUX3_GPIO_100K_PU(1)>,
> [Severity: Low]
> Does this file include the node definitions and bindings for pmk8550_vadc=
?
>=20
> The pmk8550_vadc phandle does not appear to be defined in this file or it=
s
> typical includes, which will cause a dtc compilation error when the devic=
e
> tree is built.
>=20
> Additionally, is ADC5_GEN3_AMUX3_GPIO_100K_PU intended to be used as a
> function-like macro taking an argument here?
>=20
> The dt-bindings headers usually define this as a parameterless macro.
> Supplying an argument like (1) will cause a preprocessor error during the
> device tree compilation.

..

>=20
> > +=09=09=09      <&pmk8550_vadc ADC5_GEN3_AMUX4_GPIO_100K_PU(1)>,
> [ ... ]
> > @@ -1025,6 +1049,57 @@ rtmr0_1p8_reg_en: rtmr0-1p8-reg-en-state {
> >  =09};
> >  };
> >
> > +&pmk8550_vadc {
> > +=09sys_therm0: channel@14c {
> > +=09=09reg =3D <ADC5_GEN3_AMUX3_GPIO_100K_PU(1)>;
> [Severity: Low]
> Will appending to pmk8550_vadc work if the base node does not exist?
>=20
> Similar to the io-channels property in the embedded-controller block,
> attempting to append properties to an undefined pmk8550_vadc node will
> result in a path not found error from the device tree compiler.
>=20
> The reg assignment also uses the same function-like macro syntax which
> will trigger a preprocessor failure.

Seems bot is not using latest linux-next as base. Nodes exist in
next-20260731, this series builds and works.

Alex

>=20
> > +=09=09qcom,hw-settle-time =3D <200>;
> > +=09=09qcom,ratiometric;
> > +=09=09label =3D "lpddr5_therm";
> > +=09};
> [ ... ]
>=20
> --
> Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260801-dell-xps=
[email protected]?part=3D3
>