Re: [PATCH v3 4/8] dt-bindings: mfd: syscon: add ESWIN EIC7700 compatible

Hi Sashiko,

> Thank you for your contribution! Sashiko AI review found 2 potential issu=
e(s)
> to consider:
> - [Medium] The new compatible string 'eswin,eic7700-syscfg' was omitted
> from the 'select' block's enum list in `syscon.yaml`.
> - [Low] The commit message description is not capitalized, violating MFD
> subsystem guidelines.
> --
>=20
> --- Patch [4]: [PATCH v3 4/8] dt-bindings: mfd: syscon: add ESWIN EIC7700
> compatible --- commit b6fbe8a9c92251f8d7a4c290284000e71004ed87
> Author: Pinkesh Vaghela <[email protected]>
>=20
> dt-bindings: mfd: syscon: add ESWIN EIC7700 compatible
>=20
> Document ESWIN EIC7700 SoC compatible for syscon registers.
>=20
> > dt-bindings: mfd: syscon: add ESWIN EIC7700 compatible
>=20
> [Severity: Low]
> This isn't a bug, but should the commit description be capitalized after =
the
> subsystem prefix to match MFD subsystem guidelines, perhaps using "Add
> ESWIN EIC7700 compatible"?
>=20
> [ ... ]
>=20
> > diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml
> > b/Documentation/devicetree/bindings/mfd/syscon.yaml
> > index e228670880631..2bcaaba6948d3 100644
> > --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
> > +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
> > @@ -175,6 +175,7 @@ properties:
> >                - cirrus,ep7209-syscon3
> >                - cnxt,cx92755-uc
> >                - econet,en751221-chip-scu
> > +              - eswin,eic7700-syscfg
>=20
> [Severity: Medium]
> Does this new compatible string also need to be mirrored in the select bl=
ock's
> enum list earlier in the file?
>=20
> If eswin,eic7700-syscfg is omitted from the select list:
>=20
>   select:
>     properties:
>       compatible:
>         contains:
>           enum:
>             ...
>             - econet,en751221-chip-scu
>             - freecom,fsg-cs2-system-controller
>=20
> will older tooling like dtschema < 2024.02 fail to select this schema as =
a
> fallback, which could silently allow invalid configurations to pass undet=
ected?

We rebased this patch to linux-next. Since custom select is dropped in patc=
h [1],
we don't need to add this in select.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/com=
mit/Documentation/devicetree/bindings/mfd/syscon.yaml?h=3Dnext-20260803&id=
=3D6165900f3922f923bb363d58c2893005d26d1b30

Regards,
Pinkesh
>=20
> >                - freecom,fsg-cs2-system-controller
> >                - fsl,imx93-aonmix-ns-syscfg
> >                - fsl,imx93-wakeupmix-syscfg
>=20
> --
> Sashiko AI review *
> https://nam04.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fsashi=
k
> o.dev%2F%23%2Fpatchset%2F20260804104431.1391839-1-
> pinkesh.vaghela%40einfochips.com%3Fpart%3D4&data=3D05%7C02%7Cpinkesh
> .vaghela%40einfochips.com%7C0ed0a6e6a57f412e089e08def217d38f%7C0be
> b0c359cbb4feb99e5589e415c7944%7C1%7C0%7C639214381360842991%7CU
> nknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAw
> MCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C
> &sdata=3D3EBV%2FOCsfYO41uNqK4URl2MK8gMPfGsL80nf3kE1WGs%3D&reser
> ved=3D0