Re: [PATCH v3 03/27] mtd: spi-nor: Unconditionally parse SFDP in the deprecated path

Hello all,

I find very strange to answer to a review without the normal Cc list in
copy, nor the list. I am more and more tempted to say this is a problem
and we should just let Sashiko reviews flow.

What I also find problematic is the fact that Sashiko does not learn
from one iteration to another. So people will have to keep answering the
same remarks over and over again.

Nevertheless, two comments below.

On 04/08/2026 at 11:18:05 GMT, [email protected] wrote:

> Thank you for your contribution! Sashiko AI review found 2 potential issu=
e(s) to consider:
>
> New issues:
> - [High] Unconditional SFDP probing intentionally breaks backward
> compatibility for legacy non-SFDP chips.

This is all explained in the commit log, it can be debated, but it is
already flagged.

> Pre-existing issues:
> - [High] Incomplete error rollback in
> `spi_nor_sfdp_init_params_deprecated()` leaves `nor->flags` and
> `nor->cmd_ext_type` corrupted on partial SFDP parsing failure.

This is an hallucination, the bfpt table parsing is the last step and
there is no fatal return case past the point where we set the flags.

Thanks,
Miqu=C3=A8l