Re: [PATCH] dt-bindings: mailbox: Delete old 'mailbox.txt' bindings file

Hi,

On Tue, Aug 4, 2026 at 1:44=E2=80=AFPM <[email protected]> wrote:
>
> Thank you for your contribution! Sashiko AI review found 1 potential issu=
e(s) to consider:
> - [Low] Deleting `mailbox.txt` without updating references to it in other=
 binding files leaves dangling, broken documentation references.
> --
>
> --- Patch [1]: [PATCH] dt-bindings: mailbox: Delete old 'mailbox.txt' bin=
dings file ---
> commit 1b70b3f250d6bcf306aca223e0e91c9fb8a20cc2
> Author: Douglas Anderson <[email protected]>
>
> dt-bindings: mailbox: Delete old 'mailbox.txt' bindings file
>
> This commit deletes the old mailbox.txt device-tree bindings file. The
> documentation contained in the file has been moved to the dt-schema
> repository.
>
> Link: https://lore.kernel.org/r/[email protected] [=
1]
> Link: https://lore.kernel.org/r/dc7a2041-50a4-482e-9930-566bb3fd1e72@kern=
el.org [2]
> Link: https://lore.kernel.org/r/CAL_JsqKVjQ2m-dzMUENQry-f_YE9QrYSOKoH9CPj=
[email protected] [3]
> Link: https://github.com/devicetree-org/dt-schema/pull/202 [4]
>
> > diff --git a/Documentation/devicetree/bindings/mailbox/mailbox.txt b/Do=
cumentation/devicetree/bindings/mailbox/mailbox.txt
> > deleted file mode 100644
> > index af8ecee2ac687..0000000000000
> > --- a/Documentation/devicetree/bindings/mailbox/mailbox.txt
> > +++ /dev/null
> > @@ -1,60 +0,0 @@
> > -* Generic Mailbox Controller and client driver bindings
>
> [Severity: Low]
> Does deleting this file leave dangling documentation links in other bindi=
ngs
> that still reference it?
>
> For example, there are explicit references to mailbox.txt in:
> - Documentation/devicetree/bindings/mailbox/ti,omap-mailbox.yaml
> - Documentation/devicetree/bindings/power/reset/xlnx,zynqmp-power.yaml
> - Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.yaml
> - Documentation/devicetree/bindings/firmware/nvidia,tegra186-bpmp.yaml
> - Documentation/devicetree/bindings/mailbox/allwinner,sun6i-a31-msgbox.ya=
ml
>
> [ ... ]
>
> --
> Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260804133801.1.=
I8b3ff71c528133e7d6f81fe926fa39e6451d63fd@changeid?part=3D1

Sashiko makes a good point. I'm happy to send a v2 of this patch
fixing this, but I'll wait to see if there are any other comments
first. If I don't hear anything in a week or so, I'll send a v2
anyway.

-Doug