Re: [PATCH v2 2/2] KVM: selftests: Create one VM with many vCPUs for each major PMU counters test
Sean Christopherson <[email protected]> Tue, 4 Aug 2026 13:55:08 -0700
| Newsgroups | dev.linux.lists.sashiko-reviews,org.kernel.vger.kvm |
|---|---|
| Message-ID | <[email protected]> |
On Tue, Aug 04, 2026, [email protected] wrote: > Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider: > > +static struct kvm_vm *pmu_vm_create_with_vcpus(u32 nr_vcpus, void *guest_code, > > + u8 pmu_version, > > + u64 perf_capabilities, > > + struct kvm_vcpu **__vcpus[]) > > { > > + struct kvm_vcpu **vcpus = calloc(nr_vcpus, sizeof(struct kvm_vcpu)); > > [Severity: Low] > Does this calloc() call allocate too much memory? And I managed to send the v1 patches again, *sigh*. At least Sashiko is consitent?