Re: [PATCH V3 2/2] tools/perf: Add kernel-doc comment to auxtrace_record__init() function

Athira Rajeev <[email protected]> Sat, 2 May 2026 14:00:02 +0530

Newsgroups	dev.linux.lists.sashiko,org.kernel.vger.linux-perf-users
Message-ID	<[email protected]>


> On 2 May 2026, at 1:40 PM, [email protected] wrote:
> 
> Is this description for case 'c' completely accurate?
> 
> Looking at the architecture-specific implementations, such as the one in
> tools/perf/arch/x86/util/auxtrace.c, it appears the function can return
> positive error codes. For instance, the x86 implementation calls get_cpuid(),
> which returns ENOBUFS (a positive integer) on failure. This positive value
> is then assigned to *err before returning NULL.
> 
> Could this comment be updated to reflect that *err can be any non-zero
> value on failure, rather than strictly less than zero?

Sure

I will update this in next version

Thanks
Athira