Re: [PATCH] hte: tegra-194: Convert to platform remove callback returning void

--molke6wsjwejai5x
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello Dipen,

On Mon, Mar 11, 2024 at 10:13:15AM -0700, Dipen Patel wrote:
> On 3/11/24 9:04 AM, Thierry Reding wrote:
> > On Fri Mar 8, 2024 at 9:51 AM CET, Uwe Kleine-K=F6nig wrote:
> >> The .remove() callback for a platform driver returns an int which makes
> >> many driver authors wrongly assume it's possible to do error handling =
by
> >> returning an error code. However the value returned is ignored (apart
> >> from emitting a warning) and this typically results in resource leaks.
> >>
> >> To improve here there is a quest to make the remove callback return
> >> void. In the first step of this quest all drivers are converted to
> >> .remove_new(), which already returns void. Eventually after all drivers
> >> are converted, .remove_new() will be renamed to .remove().
> >>
> >> Trivially convert this driver from always returning zero in the remove
> >> callback to the void returning variant.
> >>
> >> Signed-off-by: Uwe Kleine-K=F6nig <[email protected]>
> >> ---
> >>  drivers/hte/hte-tegra194-test.c | 6 ++----
> >>  1 file changed, 2 insertions(+), 4 deletions(-)
> >=20
> > Acked-by: Thierry Reding <[email protected]>
> Do you want me to take this patch or want to add in your patch series
> for the drivers with similar changes?
>=20
> Acked-by: Dipen Patel <[email protected]>

I don't plan (yet) to care for applying these changes myself. So if you
could pick it up that would be great.

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--molke6wsjwejai5x
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmXvazUACgkQj4D7WH0S
/k5D2AgAnv1sLVDtEOahR56KCUwwIdIYsjYXUJLR/UVExGO9lDfV2JzsfjYKM0Ww
B4geCaWoBnSXxvd4Gvx2VjoaGgqVhghu59+vTx+aPDpDJq78kdEDco7W62KpVuiE
fFhf6BwzieIGNXKBt2+tok1wVsTQjvf4oiWNc9jeDH44BjVbMbO4FFbqc/+2Yys0
ebJYXwquf5pCECz6B6leQFrSxLfvHnzRwfEaHMtvfFZQJGNXv05JL7JAgZc9SW4a
8rkC0pfsNRLXlDMWhFknK2/+YbVjB+x6+L61FPqulbd7sowLGF4kEFaO+VWC+mXZ
ySVBlY68N4K1bUdzylfn/WDL66mGdA==
=mXO2
-----END PGP SIGNATURE-----

--molke6wsjwejai5x--