Re: [PATCH] hte: tegra-194: Convert to platform remove callback returning void

--2pqly2y5cmiesnht
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello Dipen,

On Mon, Mar 11, 2024 at 09:36:06PM +0100, Uwe Kleine-K=F6nig wrote:
> On Mon, Mar 11, 2024 at 10:13:15AM -0700, Dipen Patel wrote:
> > On 3/11/24 9:04 AM, Thierry Reding wrote:
> > > On Fri Mar 8, 2024 at 9:51 AM CET, Uwe Kleine-K=F6nig wrote:
> > >> The .remove() callback for a platform driver returns an int which ma=
kes
> > >> many driver authors wrongly assume it's possible to do error handlin=
g by
> > >> returning an error code. However the value returned is ignored (apart
> > >> from emitting a warning) and this typically results in resource leak=
s.
> > >>
> > >> To improve here there is a quest to make the remove callback return
> > >> void. In the first step of this quest all drivers are converted to
> > >> .remove_new(), which already returns void. Eventually after all driv=
ers
> > >> are converted, .remove_new() will be renamed to .remove().
> > >>
> > >> Trivially convert this driver from always returning zero in the remo=
ve
> > >> callback to the void returning variant.
> > >>
> > >> Signed-off-by: Uwe Kleine-K=F6nig <[email protected]>
> > >> ---
> > >>  drivers/hte/hte-tegra194-test.c | 6 ++----
> > >>  1 file changed, 2 insertions(+), 4 deletions(-)
> > >=20
> > > Acked-by: Thierry Reding <[email protected]>
> > Do you want me to take this patch or want to add in your patch series
> > for the drivers with similar changes?
> >=20
> > Acked-by: Dipen Patel <[email protected]>
>=20
> I don't plan (yet) to care for applying these changes myself. So if you
> could pick it up that would be great.

Either you didn't pick it up or your tree isn't included in next. Both
options are not optimal in my eyes.

Given that I want to change struct platform_driver::remove in the merge
window after v6.10, it would be great if this patch made it into
v6.10-rc1.

Thanks for considering
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--2pqly2y5cmiesnht
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmYZKo0ACgkQj4D7WH0S
/k7Afwf/SCCfMG0s53JD7lAo8cdm0QiSU5H76eTfLL/5e6CKW32q3bYFoyGnZf1W
FfcV8fndw/jIefOA3aF4rzQq0Ca1j+ZEJ6RjcTHMvn3FkiS5NCzeM7E7A6tLVMOG
ScgTjKePvGjIVeCuyduKLoBf6duVV54fG+YYPK/7GoKd6t+8yKR4EoZHpU+RcqW2
qhDWDhDTBuRNmqlhw7XZrUbscaq59G3SnqQvSADn6fXyk+MuOdyrC8EhvE4dM4gc
SmwCRBfFbbhWzmH1z1kqhu8C6F5u4BGRSa7IMdUok1zeL+P2+peDvA7JHEjWhQUt
lo32vsvTdUMhPhXu/8GUBodsVV+GHg==
=3vud
-----END PGP SIGNATURE-----

--2pqly2y5cmiesnht--