Re: [cocci] [PATCH 24/61] net/9p: Prefer IS_ERR_OR_NULL over manual NULL check
Christian Schoenebeck <[email protected]> Tue, 10 Mar 2026 14:47:03 +0100
| Newsgroups | fr.inria.cocci,dev.linux.lists.dm-devel,dev.linux.lists.gfs2,dev.linux.lists.iommu,dev.linux.lists.ntfs3,dev.linux.lists.sched-ext,dev.linux.lists.v9fs,org.freedesktop.lists.amd-gfx,org.freedesktop.lists.dri-devel,org.freedesktop.lists.intel-gfx,org.infradead.lists.linux-mtd,org.infradead.lists.linux-phy,org.infradead.lists.linux-rockchip,org.kernel.vger.bpf,org.kernel.vger.ceph-devel,org.kernel.vger.kvm,org.kernel.vger.linux-block,org.kernel.vger.linux-bluetooth,org.kernel.vger.linux-btrfs,org.kernel.vger.linux-cifs,org.kernel.vger.linux-clk,org.kernel.vger.linux-ext4,org.kernel.vger.linux-fsdevel,org.kernel.vger.linux-gpio,org.kernel.vger.linux-hyperv,org.kernel.vger.linux-input,org.kernel.vger.linux-kernel,org.kernel.vger.linux-leds,org.kernel.vger.linux-media,org.kernel.vger.linux-mips,org.kernel.vger.linux-modules,org.kernel.vger.linux-nfs,org.kernel.vger.linux-omap,org.kernel.vger.linux-pm,org.kernel.vger.linux-s390,org.kernel.vger.linux-scsi,org.kernel.vger.linux-sctp,org.kernel.vger.linux-security-module,org.kernel.vger.linux-sh,org.kernel.vger.linux-sound,org.kernel.vger.linux-trace-kernel,org.kernel.vger.linux-usb,org.kernel.vger.linux-wireless,org.kernel.vger.netdev,org.kernel.vger.target-devel,org.kvack.linux-mm,org.osuosl.intel-wired-lan,org.ozlabs.lists.linux-erofs |
|---|---|
| Message-ID | <1948861.tdWV9SEqCh@weasel> |
On Tuesday, 10 March 2026 12:48:50 CET Philipp Hahn wrote: > Prefer using IS_ERR_OR_NULL() over using IS_ERR() and a manual NULL > check. > > Change generated with coccinelle. > > To: Eric Van Hensbergen <[email protected]> > To: Latchesar Ionkov <[email protected]> > To: Dominique Martinet <[email protected]> > To: Christian Schoenebeck <[email protected]> > To: "David S. Miller" <[email protected]> > To: Eric Dumazet <[email protected]> > To: Jakub Kicinski <[email protected]> > To: Paolo Abeni <[email protected]> > To: Simon Horman <[email protected]> > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Signed-off-by: Philipp Hahn <[email protected]> > --- > include/net/9p/client.h | 2 +- > net/9p/trans_rdma.c | 8 ++++---- > 2 files changed, 5 insertions(+), 5 deletions(-) Reviewed-by: Christian Schoenebeck <[email protected]> > diff --git a/include/net/9p/client.h b/include/net/9p/client.h > index > 838a94218b593f3fb19e6827c472753380193461..4bde6bd716f323c819745e64c7aac0dea > 7beb72f 100644 --- a/include/net/9p/client.h > +++ b/include/net/9p/client.h > @@ -364,7 +364,7 @@ static inline struct p9_fid *p9_fid_get(struct p9_fid > *fid) > > static inline int p9_fid_put(struct p9_fid *fid) > { > - if (!fid || IS_ERR(fid)) > + if (IS_ERR_OR_NULL(fid)) > return 0; > > if (tracepoint_enabled(9p_fid_ref)) > diff --git a/net/9p/trans_rdma.c b/net/9p/trans_rdma.c > index > aa5bd74d333f3b5e6fd1e4344d26bc0201ff7f7f..60461344b536bcb6e94112aace75a88b6 > a99ad86 100644 --- a/net/9p/trans_rdma.c > +++ b/net/9p/trans_rdma.c > @@ -252,16 +252,16 @@ static void rdma_destroy_trans(struct p9_trans_rdma > *rdma) if (!rdma) > return; > > - if (rdma->qp && !IS_ERR(rdma->qp)) > + if (!IS_ERR_OR_NULL(rdma->qp)) > ib_destroy_qp(rdma->qp); > > - if (rdma->pd && !IS_ERR(rdma->pd)) > + if (!IS_ERR_OR_NULL(rdma->pd)) > ib_dealloc_pd(rdma->pd); > > - if (rdma->cq && !IS_ERR(rdma->cq)) > + if (!IS_ERR_OR_NULL(rdma->cq)) > ib_free_cq(rdma->cq); > > - if (rdma->cm_id && !IS_ERR(rdma->cm_id)) > + if (!IS_ERR_OR_NULL(rdma->cm_id)) > rdma_destroy_id(rdma->cm_id); > > kfree(rdma);