Re: [cocci] [PATCH 25/61] net/bluetooth: Prefer IS_ERR_OR_NULL over manual NULL check
Bastien Nocera <[email protected]> Tue, 10 Mar 2026 14:55:52 +0100
| Newsgroups | fr.inria.cocci,dev.linux.lists.dm-devel,dev.linux.lists.gfs2,dev.linux.lists.iommu,dev.linux.lists.ntfs3,dev.linux.lists.sched-ext,dev.linux.lists.v9fs,org.freedesktop.lists.amd-gfx,org.freedesktop.lists.dri-devel,org.freedesktop.lists.intel-gfx,org.infradead.lists.linux-mtd,org.infradead.lists.linux-phy,org.infradead.lists.linux-rockchip,org.kernel.vger.bpf,org.kernel.vger.ceph-devel,org.kernel.vger.kvm,org.kernel.vger.linux-block,org.kernel.vger.linux-bluetooth,org.kernel.vger.linux-btrfs,org.kernel.vger.linux-cifs,org.kernel.vger.linux-clk,org.kernel.vger.linux-ext4,org.kernel.vger.linux-fsdevel,org.kernel.vger.linux-gpio,org.kernel.vger.linux-hyperv,org.kernel.vger.linux-input,org.kernel.vger.linux-kernel,org.kernel.vger.linux-leds,org.kernel.vger.linux-media,org.kernel.vger.linux-mips,org.kernel.vger.linux-modules,org.kernel.vger.linux-nfs,org.kernel.vger.linux-omap,org.kernel.vger.linux-pm,org.kernel.vger.linux-s390,org.kernel.vger.linux-scsi,org.kernel.vger.linux-sctp,org.kernel.vger.linux-security-module,org.kernel.vger.linux-sh,org.kernel.vger.linux-sound,org.kernel.vger.linux-trace-kernel,org.kernel.vger.linux-usb,org.kernel.vger.linux-wireless,org.kernel.vger.netdev,org.kernel.vger.target-devel,org.kvack.linux-mm,org.osuosl.intel-wired-lan,org.ozlabs.lists.linux-erofs |
|---|---|
| Message-ID | <[email protected]> |
On Tue, 2026-03-10 at 12:48 +0100, Philipp Hahn wrote: > Prefer using IS_ERR_OR_NULL() over using IS_ERR() and a manual NULL > check. > > Change generated with coccinelle. > > To: Marcel Holtmann <[email protected]> > To: Johan Hedberg <[email protected]> > To: Luiz Augusto von Dentz <[email protected]> > Cc: [email protected] > Cc: [email protected] > Signed-off-by: Philipp Hahn <[email protected]> Reviewed-by: Bastien Nocera <[email protected]> > --- > net/bluetooth/mgmt.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c > index > a7238fd3b03bb54f39af1afee74dc1acd931c324..06d2da67bbe14e17ee478aa939d > e26526c333d91 100644 > --- a/net/bluetooth/mgmt.c > +++ b/net/bluetooth/mgmt.c > @@ -4169,7 +4169,7 @@ static void set_default_phy_complete(struct > hci_dev *hdev, void *data, int err) > mgmt_phy_configuration_changed(hdev, cmd->sk); > } > > - if (skb && !IS_ERR(skb)) > + if (!IS_ERR_OR_NULL(skb)) > kfree_skb(skb); > > mgmt_pending_free(cmd); > @@ -5730,7 +5730,7 @@ static void read_local_oob_data_complete(struct > hci_dev *hdev, void *data, > MGMT_STATUS_SUCCESS, &mgmt_rp, rp_size); > > remove: > - if (skb && !IS_ERR(skb)) > + if (!IS_ERR_OR_NULL(skb)) > kfree_skb(skb); > > mgmt_pending_free(cmd); > @@ -8277,7 +8277,7 @@ static void > read_local_oob_ext_data_complete(struct hci_dev *hdev, void *data, > mgmt_rp, sizeof(*mgmt_rp) + > eir_len, > HCI_MGMT_OOB_DATA_EVENTS, cmd->sk); > done: > - if (skb && !IS_ERR(skb)) > + if (!IS_ERR_OR_NULL(skb)) > kfree_skb(skb); > > kfree(mgmt_rp);