RE: [cocci] [Intel-wired-lan] [PATCH 28/61] net/sched: Prefer IS_ERR_OR_NULL over manual NULL check
"Loktionov, Aleksandr" <[email protected]> Wed, 11 Mar 2026 09:22:21 +0000
| Newsgroups | fr.inria.cocci,dev.linux.lists.dm-devel,dev.linux.lists.gfs2,dev.linux.lists.iommu,dev.linux.lists.ntfs3,dev.linux.lists.sched-ext,dev.linux.lists.v9fs,org.freedesktop.lists.amd-gfx,org.freedesktop.lists.dri-devel,org.freedesktop.lists.intel-gfx,org.infradead.lists.linux-mtd,org.infradead.lists.linux-phy,org.infradead.lists.linux-rockchip,org.kernel.vger.bpf,org.kernel.vger.ceph-devel,org.kernel.vger.kvm,org.kernel.vger.linux-block,org.kernel.vger.linux-bluetooth,org.kernel.vger.linux-btrfs,org.kernel.vger.linux-cifs,org.kernel.vger.linux-clk,org.kernel.vger.linux-ext4,org.kernel.vger.linux-fsdevel,org.kernel.vger.linux-gpio,org.kernel.vger.linux-hyperv,org.kernel.vger.linux-input,org.kernel.vger.linux-kernel,org.kernel.vger.linux-leds,org.kernel.vger.linux-media,org.kernel.vger.linux-mips,org.kernel.vger.linux-modules,org.kernel.vger.linux-nfs,org.kernel.vger.linux-omap,org.kernel.vger.linux-pm,org.kernel.vger.linux-s390,org.kernel.vger.linux-scsi,org.kernel.vger.linux-sctp,org.kernel.vger.linux-security-module,org.kernel.vger.linux-sh,org.kernel.vger.linux-sound,org.kernel.vger.linux-trace-kernel,org.kernel.vger.linux-usb,org.kernel.vger.linux-wireless,org.kernel.vger.netdev,org.kernel.vger.target-devel,org.kvack.linux-mm,org.osuosl.intel-wired-lan,org.ozlabs.lists.linux-erofs |
|---|---|
| Message-ID | <IA3PR11MB8986B4E436132BCDF617CD4AE547A@IA3PR11MB8986.namprd11.prod.outlook.com> |
> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf > Of Philipp Hahn > Sent: Tuesday, March 10, 2026 12:49 PM > To: [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; dm- > [email protected]; [email protected]; > [email protected]; [email protected]; intel-wired- > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; > [email protected]; [email protected]; linux- > [email protected]; [email protected]; linux- > [email protected]; [email protected]; linux- > [email protected]; [email protected]; linux- > [email protected]; [email protected]; linux- > [email protected]; [email protected]; linux- > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; linux- > [email protected]; [email protected]; linux- > [email protected]; [email protected]; linux- > [email protected]; [email protected]; linux- > [email protected]; [email protected]; linux-security- > [email protected]; [email protected]; linux- > [email protected]; [email protected]; > [email protected]; [email protected]; linux- > [email protected]; [email protected]; > [email protected]; [email protected]; sched- > [email protected]; [email protected]; tipc- > [email protected]; [email protected]; Philipp Hahn > <[email protected]> > Cc: Hadi Salim, Jamal <[email protected]>; Jiri Pirko > <[email protected]>; David S. Miller <[email protected]>; Eric > Dumazet <[email protected]>; Jakub Kicinski <[email protected]>; Paolo > Abeni <[email protected]>; Simon Horman <[email protected]> > Subject: [Intel-wired-lan] [PATCH 28/61] net/sched: Prefer > IS_ERR_OR_NULL over manual NULL check > > Prefer using IS_ERR_OR_NULL() over using IS_ERR() and a manual NULL > check. > > Change generated with coccinelle. > > To: Jamal Hadi Salim <[email protected]> > To: Jiri Pirko <[email protected]> > To: "David S. Miller" <[email protected]> > To: Eric Dumazet <[email protected]> > To: Jakub Kicinski <[email protected]> > To: Paolo Abeni <[email protected]> > To: Simon Horman <[email protected]> > Cc: [email protected] > Cc: [email protected] > Signed-off-by: Philipp Hahn <[email protected]> > --- > net/sched/cls_api.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c index > 4829c27446e3369ad2ae9b3fcb285eca47d59933..4208225e7a4acaf0c331096ebf94 > 1f68cc2ed992 100644 > --- a/net/sched/cls_api.c > +++ b/net/sched/cls_api.c > @@ -2444,7 +2444,7 @@ static int tc_new_tfilter(struct sk_buff *skb, > struct nlmsghdr *n, > tcf_chain_tp_delete_empty(chain, tp, rtnl_held, NULL); > errout_tp: > if (chain) { > - if (tp && !IS_ERR(tp)) > + if (!IS_ERR_OR_NULL(tp)) > tcf_proto_put(tp, rtnl_held, NULL); > if (!tp_created) > tcf_chain_put(chain); > @@ -2612,7 +2612,7 @@ static int tc_del_tfilter(struct sk_buff *skb, > struct nlmsghdr *n, > > errout: > if (chain) { > - if (tp && !IS_ERR(tp)) > + if (!IS_ERR_OR_NULL(tp)) > tcf_proto_put(tp, rtnl_held, NULL); > tcf_chain_put(chain); > } > @@ -2741,7 +2741,7 @@ static int tc_get_tfilter(struct sk_buff *skb, > struct nlmsghdr *n, > tfilter_put(tp, fh); > errout: > if (chain) { > - if (tp && !IS_ERR(tp)) > + if (!IS_ERR_OR_NULL(tp)) > tcf_proto_put(tp, rtnl_held, NULL); > tcf_chain_put(chain); > } > > -- > 2.43.0 Reviewed-by: Aleksandr Loktionov <[email protected]>