RE: [cocci] [Intel-wired-lan] [PATCH 30/61] net/sunrpc: Prefer IS_ERR_OR_NULL over manual NULL check
"Loktionov, Aleksandr" <[email protected]> Wed, 11 Mar 2026 09:22:46 +0000
| Newsgroups | fr.inria.cocci,dev.linux.lists.dm-devel,dev.linux.lists.gfs2,dev.linux.lists.iommu,dev.linux.lists.ntfs3,dev.linux.lists.sched-ext,dev.linux.lists.v9fs,org.freedesktop.lists.amd-gfx,org.freedesktop.lists.dri-devel,org.freedesktop.lists.intel-gfx,org.infradead.lists.linux-mtd,org.infradead.lists.linux-phy,org.infradead.lists.linux-rockchip,org.kernel.vger.bpf,org.kernel.vger.ceph-devel,org.kernel.vger.kvm,org.kernel.vger.linux-block,org.kernel.vger.linux-bluetooth,org.kernel.vger.linux-btrfs,org.kernel.vger.linux-cifs,org.kernel.vger.linux-clk,org.kernel.vger.linux-ext4,org.kernel.vger.linux-fsdevel,org.kernel.vger.linux-gpio,org.kernel.vger.linux-hyperv,org.kernel.vger.linux-input,org.kernel.vger.linux-kernel,org.kernel.vger.linux-leds,org.kernel.vger.linux-media,org.kernel.vger.linux-mips,org.kernel.vger.linux-modules,org.kernel.vger.linux-nfs,org.kernel.vger.linux-omap,org.kernel.vger.linux-pm,org.kernel.vger.linux-s390,org.kernel.vger.linux-scsi,org.kernel.vger.linux-sctp,org.kernel.vger.linux-security-module,org.kernel.vger.linux-sh,org.kernel.vger.linux-sound,org.kernel.vger.linux-trace-kernel,org.kernel.vger.linux-usb,org.kernel.vger.linux-wireless,org.kernel.vger.netdev,org.kernel.vger.target-devel,org.kvack.linux-mm,org.osuosl.intel-wired-lan,org.ozlabs.lists.linux-erofs |
|---|---|
| Message-ID | <IA3PR11MB8986B27E91681D79D9D8A387E547A@IA3PR11MB8986.namprd11.prod.outlook.com> |
> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf > Of Philipp Hahn > Sent: Tuesday, March 10, 2026 12:49 PM > To: [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; dm- > [email protected]; [email protected]; > [email protected]; [email protected]; intel-wired- > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; > [email protected]; [email protected]; linux- > [email protected]; [email protected]; linux- > [email protected]; [email protected]; linux- > [email protected]; [email protected]; linux- > [email protected]; [email protected]; linux- > [email protected]; [email protected]; linux- > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; linux- > [email protected]; [email protected]; linux- > [email protected]; [email protected]; linux- > [email protected]; [email protected]; linux- > [email protected]; [email protected]; linux-security- > [email protected]; [email protected]; linux- > [email protected]; [email protected]; > [email protected]; [email protected]; linux- > [email protected]; [email protected]; > [email protected]; [email protected]; sched- > [email protected]; [email protected]; tipc- > [email protected]; [email protected]; Philipp Hahn > <[email protected]> > Cc: Trond Myklebust <[email protected]>; Anna Schumaker > <[email protected]>; Chuck Lever <[email protected]>; Jeff Layton > <[email protected]>; NeilBrown <[email protected]>; Olga Kornievskaia > <[email protected]>; Dai Ngo <[email protected]>; Tom Talpey > <[email protected]>; David S. Miller <[email protected]>; Eric Dumazet > <[email protected]>; Jakub Kicinski <[email protected]>; Paolo Abeni > <[email protected]>; Simon Horman <[email protected]> > Subject: [Intel-wired-lan] [PATCH 30/61] net/sunrpc: Prefer > IS_ERR_OR_NULL over manual NULL check > > Prefer using IS_ERR_OR_NULL() over using IS_ERR() and a manual NULL > check. > > Change generated with coccinelle. > > To: Trond Myklebust <[email protected]> > To: Anna Schumaker <[email protected]> > To: Chuck Lever <[email protected]> > To: Jeff Layton <[email protected]> > To: NeilBrown <[email protected]> > To: Olga Kornievskaia <[email protected]> > To: Dai Ngo <[email protected]> > To: Tom Talpey <[email protected]> > To: "David S. Miller" <[email protected]> > To: Eric Dumazet <[email protected]> > To: Jakub Kicinski <[email protected]> > To: Paolo Abeni <[email protected]> > To: Simon Horman <[email protected]> > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Signed-off-by: Philipp Hahn <[email protected]> > --- > net/sunrpc/xprtrdma/svc_rdma_transport.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/net/sunrpc/xprtrdma/svc_rdma_transport.c > b/net/sunrpc/xprtrdma/svc_rdma_transport.c > index > 9b623849723ed0eb74b827881c6f32d3434c891b..b4d03e59a8202f20360cff1e2e79 > b1e325396517 100644 > --- a/net/sunrpc/xprtrdma/svc_rdma_transport.c > +++ b/net/sunrpc/xprtrdma/svc_rdma_transport.c > @@ -578,7 +578,7 @@ static struct svc_xprt *svc_rdma_accept(struct > svc_xprt *xprt) > errout: > /* Take a reference in case the DTO handler runs */ > svc_xprt_get(&newxprt->sc_xprt); > - if (newxprt->sc_qp && !IS_ERR(newxprt->sc_qp)) > + if (!IS_ERR_OR_NULL(newxprt->sc_qp)) > ib_destroy_qp(newxprt->sc_qp); > rdma_destroy_id(newxprt->sc_cm_id); > rpcrdma_rn_unregister(dev, &newxprt->sc_rn); @@ -608,7 +608,7 > @@ static void svc_rdma_free(struct svc_xprt *xprt) > might_sleep(); > > /* This blocks until the Completion Queues are empty */ > - if (rdma->sc_qp && !IS_ERR(rdma->sc_qp)) > + if (!IS_ERR_OR_NULL(rdma->sc_qp)) > ib_drain_qp(rdma->sc_qp); > flush_workqueue(svcrdma_wq); > > @@ -619,16 +619,16 @@ static void svc_rdma_free(struct svc_xprt *xprt) > svc_rdma_recv_ctxts_destroy(rdma); > > /* Destroy the QP if present (not a listener) */ > - if (rdma->sc_qp && !IS_ERR(rdma->sc_qp)) > + if (!IS_ERR_OR_NULL(rdma->sc_qp)) > ib_destroy_qp(rdma->sc_qp); > > - if (rdma->sc_sq_cq && !IS_ERR(rdma->sc_sq_cq)) > + if (!IS_ERR_OR_NULL(rdma->sc_sq_cq)) > ib_free_cq(rdma->sc_sq_cq); > > - if (rdma->sc_rq_cq && !IS_ERR(rdma->sc_rq_cq)) > + if (!IS_ERR_OR_NULL(rdma->sc_rq_cq)) > ib_free_cq(rdma->sc_rq_cq); > > - if (rdma->sc_pd && !IS_ERR(rdma->sc_pd)) > + if (!IS_ERR_OR_NULL(rdma->sc_pd)) > ib_dealloc_pd(rdma->sc_pd); > > /* Destroy the CM ID */ > > -- > 2.43.0 Reviewed-by: Aleksandr Loktionov <[email protected]>