Re: [PATCH net-next 01/11] net: stmmac: Make stmmac_pltfr_remove() return void
Jernej Škrabec <[email protected]> Sun, 02 Apr 2023 16:41:14 +0200
| Newsgroups | io.groups.linux-oxnas,dev.linux.lists.linux-sunxi,org.infradead.lists.linux-amlogic,org.infradead.lists.linux-arm-kernel,org.infradead.lists.linux-mediatek,org.kernel.vger.netdev |
|---|---|
| Message-ID | <2674462.mvXUDI8C0e@jernej-laptop> |
Dne nedelja, 02. april 2023 ob 16:30:15 CEST je Uwe Kleine-K=F6nig napisal(= a): > The function returns zero unconditionally. Change it to return void inste= ad > which simplifies some callers as error handing becomes unnecessary. >=20 > The function is also used for some drivers as remove callback. Switch the= se > to the .remove_new() callback. For some others no error can happen in the > remove callback now, convert them to .remove_new(), too. >=20 > Signed-off-by: Uwe Kleine-K=F6nig <[email protected]> > --- > drivers/net/ethernet/stmicro/stmmac/dwmac-anarion.c | 2 +- > drivers/net/ethernet/stmicro/stmmac/dwmac-generic.c | 2 +- > drivers/net/ethernet/stmicro/stmmac/dwmac-imx.c | 2 +- > drivers/net/ethernet/stmicro/stmmac/dwmac-ingenic.c | 2 +- > drivers/net/ethernet/stmicro/stmmac/dwmac-intel-plat.c | 9 +++------ > drivers/net/ethernet/stmicro/stmmac/dwmac-ipq806x.c | 2 +- > drivers/net/ethernet/stmicro/stmmac/dwmac-lpc18xx.c | 2 +- > drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c | 9 +++------ > drivers/net/ethernet/stmicro/stmmac/dwmac-meson.c | 2 +- > drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c | 2 +- > drivers/net/ethernet/stmicro/stmmac/dwmac-oxnas.c | 2 +- > drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 5 ++--- > drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c | 2 +- > drivers/net/ethernet/stmicro/stmmac/dwmac-sunxi.c | 2 +- For sunxi: Acked-by: Jernej Skrabec <[email protected]> Best regards, Jernej > drivers/net/ethernet/stmicro/stmmac/dwmac-visconti.c | 4 +--- > drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 4 +--- > drivers/net/ethernet/stmicro/stmmac/stmmac_platform.h | 2 +- > 17 files changed, 22 insertions(+), 33 deletions(-)