Re: [PATCH net-next 01/11] net: stmmac: Make stmmac_pltfr_remove() return void
Simon Horman <[email protected]> Mon, 3 Apr 2023 17:55:20 +0200
| Newsgroups | io.groups.linux-oxnas,dev.linux.lists.linux-sunxi,org.infradead.lists.linux-amlogic,org.infradead.lists.linux-arm-kernel,org.infradead.lists.linux-mediatek,org.kernel.vger.netdev |
|---|---|
| Message-ID | <[email protected]> |
On Sun, Apr 02, 2023 at 04:30:15PM +0200, Uwe Kleine-K=C3=B6nig wrote: > The function returns zero unconditionally. Change it to return void inste= ad > which simplifies some callers as error handing becomes unnecessary. >=20 > The function is also used for some drivers as remove callback. Switch the= se > to the .remove_new() callback. For some others no error can happen in the > remove callback now, convert them to .remove_new(), too. >=20 > Signed-off-by: Uwe Kleine-K=C3=B6nig <[email protected]> Reviewed-by: Simon Horman <[email protected]>