Re: [PATCH 00/49] mtd: nand: Convert to platform remove callback returning void
Tudor Ambarus <[email protected]> Mon, 3 Apr 2023 17:29:59 +0100
| Newsgroups | io.groups.linux-oxnas,dev.linux.lists.linux-sunxi,org.infradead.lists.linux-amlogic,org.infradead.lists.linux-mediatek,org.infradead.lists.linux-mtd,org.infradead.lists.linux-rockchip,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-mips,org.kernel.vger.linux-renesas-soc,org.kernel.vger.linux-tegra |
|---|---|
| Message-ID | <[email protected]> |
On 4/1/23 17:18, Uwe Kleine-König wrote: > Hello, > > this series adapts the platform drivers below drivers/mtd/nand to use the > .remove_new() callback. Compared to the traditional .remove() callback > .remove_new() returns no value. This is a good thing because the driver core > doesn't (and cannot) cope for errors during remove. The only effect of a > non-zero return value in .remove() is that the driver core emits a warning. The > device is removed anyhow and an early return from .remove() usually yields a > resource leak. > > By changing the remove callback to return void driver authors cannot > reasonably assume any more that there is some kind of cleanup later. > > As all drivers already return 0 in their .remove callback, they can be > converted trivially. > I'd make a single patch per subsystem for trivial changes, but I don't mind having them split per driver either: Acked-by: Tudor Ambarus <[email protected]>