Re: [PATCH] global: Correct duplicate U_BOOT_DRIVER entry names
Tom Rini <[email protected]> Tue, 24 Mar 2026 08:59:10 -0600
| Newsgroups | io.groups.u-boot-amlogic,org.u-boot-project.lists.u-boot |
|---|---|
| Message-ID | <20260324145910.GP502704@bill-the-cat> |
--Groupsio=e3yQP50mWARQvZG1XNcz
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Tue, Mar 24, 2026 at 12:28:13AM +0100, Marek Vasut wrote:
>=20
> [...]
>=20
> > diff --git a/drivers/usb/dwc3/dwc3-meson-g12a.c b/drivers/usb/dwc3/dwc3=
-meson-g12a.c
> > index 41d15996e5b2..49e9c3fa0e99 100644
> > --- a/drivers/usb/dwc3/dwc3-meson-g12a.c
> > +++ b/drivers/usb/dwc3/dwc3-meson-g12a.c
> > @@ -533,7 +533,7 @@ static const struct udevice_id dwc3_meson_g12a_ids[=
] =3D {
> > { }
> > };
> > -U_BOOT_DRIVER(dwc3_generic_wrapper) =3D {
> > +U_BOOT_DRIVER(dwc3_meson_g12a) =3D {
>=20
> Could you please add usb_ as a prefix in front those usb drivers ?
As we talked about on IRC a bit, globally we're not consistent with
prefix or suffix or nothing. Your suggestion of a new macro that takes
the uclass name and rest of the driver name and constructs U_BOOT_DRIVER
from that sounds great and would be a good general improvement. If you
can file an issue about it please I'll try and find some time to look in
to doing that.
--=20
Tom
--Groupsio=e3yQP50mWARQvZG1XNcz
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iHUEABYKAB0WIQTzzqh0PWDgGS+bTHor4qD1Cr/kCgUCacKmugAKCRAr4qD1Cr/k
CmpyAQCuN4p26T/REii2QoFiw0+VYKRzKAkpxhJdroMVZggDdAEA6sQoSKo9eVVD
YEQJqehffXAcWEV/EoPeILkWOYavEgU=
=m20y
-----END PGP SIGNATURE-----
--Groupsio=e3yQP50mWARQvZG1XNcz--