Re: [PATCH] global: Correct duplicate U_BOOT_DRIVER entry names

Simon Glass <[email protected]> Tue, 24 Mar 2026 11:41:30 -0600
Newsgroups io.groups.u-boot-amlogic,org.u-boot-project.lists.u-boot
Message-ID <CAFLszTjN7ZSkc0vfT_KmN9um+v=--RRyV5OzJSWVirOT2fZWMA@mail.gmail.com>
On Mon, 23 Mar 2026 at 16:55, Tom Rini <[email protected]> wrote:
>
> The U_BOOT_DRIVER macro creates a list of drivers used at link time, and
> all entries here must be unique. This in turn means that all entries in
> the code should also be unique in order to not lead to build failures
> later with unexpected build combinations. Typically, the problem we have
> here is when a driver is obviously based on another driver and didn't
> update this particular field and so while the name field reflects
> something unique the linker entry itself is not. In a few places this
> provides a more suitable string name as well, however.
>
> Signed-off-by: Tom Rini <[email protected]>
> ---
> Cc: Anatolij Gustschin <[email protected]>
> Cc: Bin Meng <[email protected]>
> Cc: Casey Connolly <[email protected]>
> Cc: Heiko Schocher <[email protected]>
> Cc: Jaehoon Chung <[email protected]>
> Cc: Jerome Forissier <[email protected]>
> Cc: Kever Yang <[email protected]>
> Cc: =C5=81ukasz Majewski <[email protected]>
> Cc: Marek Vasut <[email protected]>
> Cc: Masahisa Kojima <[email protected]>
> Cc: Matthias Brugger <[email protected]>
> Cc: Neil Armstrong <[email protected]>
> Cc: Patrice Chotard <[email protected]>
> Cc: Patrick Delaunay <[email protected]>
> Cc: Peng Fan <[email protected]>
> Cc: Peter Robinson <[email protected]>
> Cc: Philipp Tomsich <[email protected]>
> Cc: Simon Glass <[email protected]>
> Cc: Simon Goldschmidt <[email protected]>
> Cc: Stefan Roese <[email protected]>
> Cc: Svyatoslav Ryhel <[email protected]>
> Cc: Thierry Reding <[email protected]>
> Cc: Tien Fong Chee <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> ---
>  arch/x86/cpu/broadwell/sdram.c             | 2 +-
>  arch/x86/cpu/ivybridge/early_me.c          | 2 +-
[..]

For x86:

Reviewed-by: Simon Glass <[email protected]>