Re: [PATCH 07/14] power: domain: meson-ee-pwrc: Staticize and constify driver ops

Neil Armstrong <[email protected]> Fri, 5 Jun 2026 15:09:06 +0200
Newsgroups io.groups.u-boot-amlogic,de.denx.lists.u-boot
Organization Linaro
Message-ID <[email protected]>
On 5/8/26 14:22, Marek Vasut wrote:
> Set the ops structure as static const. The structure is not accessible
> from outside of this driver and is not going to be modified at runtime.
> 
> Signed-off-by: Marek Vasut <[email protected]>
> ---
> Cc: Jaehoon Chung <[email protected]>
> Cc: Neil Armstrong <[email protected]>
> Cc: Peng Fan <[email protected]>
> Cc: Tom Rini <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> ---
>   drivers/power/domain/meson-ee-pwrc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/power/domain/meson-ee-pwrc.c b/drivers/power/domain/meson-ee-pwrc.c
> index 4d9f3bba644..6361f3a6c59 100644
> --- a/drivers/power/domain/meson-ee-pwrc.c
> +++ b/drivers/power/domain/meson-ee-pwrc.c
> @@ -386,7 +386,7 @@ static int meson_ee_pwrc_of_xlate(struct power_domain *power_domain,
>   	return 0;
>   }
>   
> -struct power_domain_ops meson_ee_pwrc_ops = {
> +static const struct power_domain_ops meson_ee_pwrc_ops = {
>   	.off = meson_ee_pwrc_off,
>   	.on = meson_ee_pwrc_on,
>   	.of_xlate = meson_ee_pwrc_of_xlate,

Reviewed-by: Neil Armstrong <[email protected]>

Thanks,
Neil