Re: [PATCH 08/14] power: domain: meson-gx-pwrc: Staticize and constify driver ops

Neil Armstrong <[email protected]> Fri, 5 Jun 2026 15:09:27 +0200
Newsgroups io.groups.u-boot-amlogic,de.denx.lists.u-boot
Organization Linaro
Message-ID <[email protected]>
On 5/8/26 14:22, Marek Vasut wrote:
> Set the ops structure as static const. The structure is not accessible
> from outside of this driver and is not going to be modified at runtime.
> 
> Signed-off-by: Marek Vasut <[email protected]>
> ---
> Cc: Jaehoon Chung <[email protected]>
> Cc: Neil Armstrong <[email protected]>
> Cc: Peng Fan <[email protected]>
> Cc: Tom Rini <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> ---
>   drivers/power/domain/meson-gx-pwrc-vpu.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/power/domain/meson-gx-pwrc-vpu.c b/drivers/power/domain/meson-gx-pwrc-vpu.c
> index 1c56e8508c3..325296b0dd7 100644
> --- a/drivers/power/domain/meson-gx-pwrc-vpu.c
> +++ b/drivers/power/domain/meson-gx-pwrc-vpu.c
> @@ -262,7 +262,7 @@ static int meson_pwrc_vpu_of_xlate(struct power_domain *power_domain,
>   	return 0;
>   }
>   
> -struct power_domain_ops meson_gx_pwrc_vpu_ops = {
> +static const struct power_domain_ops meson_gx_pwrc_vpu_ops = {
>   	.off = meson_pwrc_vpu_off,
>   	.on = meson_pwrc_vpu_on,
>   	.of_xlate = meson_pwrc_vpu_of_xlate,

Reviewed-by: Neil Armstrong <[email protected]>

Thanks,
Neil