Re: [Buildroot] [PATCH v2 02/11] package/mpd: remove duplicated dependencies from sub-options
Thomas Petazzoni via buildroot <[email protected]>
| Newsgroups | net.busybox.buildroot |
|---|---|
| Message-ID | <aoC_d9SXLJGYRqR4@windsurf> |
Hello Andreas, Thanks for your patch! On Thu, Jul 09, 2026 at 01:08:06PM +0200, Andreas Ziegler wrote: > After various updates since version 0.20, most dependencies placing > restrictions on sub-components are now superseded by restrictions placed on > MPD itself. Example: io_uring needs kernel headers > 5.1; MPD needs kernel > headers > 5.6. > > Remove dependencies from sub-options if they are already imposed on MPD. > > Signed-off-by: Andreas Ziegler <[email protected]> Actually the general policy in Buildroot is somewhat the opposite of what you're proposing here, even though I admit our general policy may not be applied anywhere. The reasoning for this policy is that it is either to review/verify when an option "select" another one, that all "depends on" have properly been replicated. Yes, this means potentially some duplication of "depends on" between the main package option and the sub-options, but it also allows to ensure that if we remove/change one of those "depends on" from the main package option, we don't forget to have it on the sub-option. Best regards, Thomas -- Thomas Petazzoni, co-owner and CEO, Bootlin Embedded Linux and Kernel engineering and training https://bootlin.com _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot