[Openvpn-devel] [M] Change in openvpn[master]: oob: Add client PROBE_REPLY parser

Attention is currently required from: flichtenheld, plaisthos.

stipa has posted comments on this change by stipa. ( http://gerrit.openvpn.net/c/openvpn/+/1745?usp=email )

Change subject: oob: Add client PROBE_REPLY parser
......................................................................


Patch Set 9:

(4 comments)

File src/openvpn/oob.c:

http://gerrit.openvpn.net/c/openvpn/+/1745/comment/4f18c478_99a430d6?usp=email :
PS8, Line 191:         }
> In the happy case we do not check that the length is valid and inside the buffer
Agreed


http://gerrit.openvpn.net/c/openvpn/+/1745/comment/b29199f5_f8ba17ab?usp=email :
PS8, Line 196:         }
> for the other case we check this.
Acknowledged


http://gerrit.openvpn.net/c/openvpn/+/1745/comment/e97eca80_b488fab9?usp=email :
PS8, Line 198:     return false;
> Can we have nicer formatting of methods? I find this style of everything squished together not great […]
Acknowledged


http://gerrit.openvpn.net/c/openvpn/+/1745/comment/360ffd19_947eda0f?usp=email :
PS8, Line 207:            && oob_probe_parameter_read(payload, param, value_len);
> I am just at this and I wonder if we can improve the code. […]
Changed the API to return the value as a buffer instead of a length. One
buf_read_alloc() now validates the header's length for both the matching and the
skipped TLVs, and the value_len parameter is dropped.



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1745?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: If04ce09d4c353f5384c0c48f48f63e05869a373f
Gerrit-Change-Number: 1745
Gerrit-PatchSet: 9
Gerrit-Owner: stipa <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Comment-Date: Tue, 28 Jul 2026 15:05:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: plaisthos <[email protected]>

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel