[Openvpn-devel] [M] Change in openvpn[master]: oob: Unwrap tls-crypt-v2 server probes (P_CONTROL_OOB_WKC_V1)

Attention is currently required from: plaisthos.

stipa has posted comments on this change by stipa. ( http://gerrit.openvpn.net/c/openvpn/+/1758?usp=email )

Change subject: oob: Unwrap tls-crypt-v2 server probes (P_CONTROL_OOB_WKC_V1)
......................................................................


Patch Set 11:

(2 comments)

File src/openvpn/ssl_pkt.h:

http://gerrit.openvpn.net/c/openvpn/+/1758/comment/638b609b_0d9444b7?usp=email :
PS10, Line 79:  * protocol (CONTROL_OOB_WKC_V1). */
> This apparently is also not a legal op code since P_LAST_OPCODE was not touched.
Already fixed by opcode-gate work.


File src/openvpn/ssl_pkt.c:

http://gerrit.openvpn.net/c/openvpn/+/1758/comment/d7b487ea_fbed9cf1?usp=email :
PS10, Line 400:         return VERDICT_VALID_OOB_V1;
> Either have VERDICT_VALID_OOB_WKC_V1 or also have categories/consolidate some of the other enums tog […]
Agreed. Enum is per-opcode everywhere else. Added VERDICT_VALID_OOB_WKC_V1 and grouped in do_pre_decrypt_check(). Reply_flags are now coming from the verdict instead of checking tls_wrap_tmp.cleanup_key_ctx.



-- 
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1758?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Idb8c0c660a98de8ec549b69f6692a7b41b092eaf
Gerrit-Change-Number: 1758
Gerrit-PatchSet: 11
Gerrit-Owner: stipa <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Comment-Date: Tue, 28 Jul 2026 15:05:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: plaisthos <[email protected]>

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel