[Openvpn-devel] [L] Change in openvpn[master]: Use OpenSSL's SIPHASH implementation to double check our implementation
"flichtenheld \(Code Review\) via Openvpn-devel" <[email protected]> Thu, 30 Jul 2026 18:23:45 +0000
| Newsgroups | net.sourceforge.lists.openvpn-devel |
|---|---|
| Message-ID | <45a728f186118971babe033775912a415833e6c4-EmailReviewComments-HTML@gerrit.openvpn.net> |
--===============4344579062079425623== Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="7zNF1HjOYtk="; charset=UTF-8 --7zNF1HjOYtk= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos=2E flichtenheld has posted= comments on this change by plaisthos=2E ( http://gerrit=2Eopenvpn=2Enet/c/= openvpn/+/31?usp=3Demail ) Change subject: Use OpenSSL's SIPHASH implement= ation to double check our implementation =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E Patch Set 30: Code-Review+2 (4 comments) Fi= le CMakeLists=2Etxt: http://gerrit=2Eopenvpn=2Enet/c/openvpn/+/31/comment/= 9105e2b1_f784d6bb?usp=3Demail : PS28, Line 801: target_compile_definiti= ons(test_crypto PRIVATE PREFER_OPENSSL_SIPHASH) > Does this still do anythi= ng? Done File tests/unit_tests/openvpn/Makefile=2Eam: http://gerrit=2Eop= envpn=2Enet/c/openvpn/+/31/comment/13bc8e15_e9fb0f81?usp=3Demail : PS28, Li= ne 102: -DPREFER_OPENSSL_SIPHASH \ > Does this still do anything? Done F= ile tests/unit_tests/openvpn/siphash_openssl=2Eh: http://gerrit=2Eopenvpn= =2Enet/c/openvpn/+/31/comment/c2a5f74c_9ec317f0?usp=3Demail : PS28, Line 2:= * SipHash reference C implementation > Wrong copyright header Done File= tests/unit_tests/openvpn/siphash_openssl=2Ec: http://gerrit=2Eopenvpn=2En= et/c/openvpn/+/31/comment/e652f08a_7890d92e?usp=3Demail : PS28, Line 35: *= implementation, so we only use for unit testing that our impelmentation > = "use it" [=E2=80=A6] Done -- To view, visit http://gerrit=2Eopenvpn=2En= et/c/openvpn/+/31?usp=3Demail To unsubscribe, or for help writing mail filt= ers, visit http://gerrit=2Eopenvpn=2Enet/settings?usp=3Demail Gerrit-Messa= geType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change= -Id: I09aa27caa1a3aab0d1be6118b26d54a1c1bf7aa0 Gerrit-Change-Number: 31 Ger= rit-PatchSet: 30 Gerrit-Owner: plaisthos <arne-openvpn@rfc2549=2Eorg> Gerri= t-Reviewer: flichtenheld <frank@lichtenheld=2Ecom> Gerrit-CC: openvpn-devel= <openvpn-devel@lists=2Esourceforge=2Enet> Gerrit-Attention: plaisthos <arn= e-openvpn@rfc2549=2Eorg> Gerrit-Comment-Date: Thu, 30 Jul 2026 18:23:45 +00= 00 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: flic= htenheld <frank@lichtenheld=2Ecom> --7zNF1HjOYtk= Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable <!DOCTYPE html><html><head><style></style></head><body><p> Attention is cur= rently required from: plaisthos=2E </p> <p>Patch set 30:<span style=3D"bord= er-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;backgrou= nd-color: #d4ffd4;">Code-Review +2</span></p><p><a href=3D"http://gerrit=2E= openvpn=2Enet/c/openvpn/+/31?usp=3Demail">View Change</a></p><p>4 comments:= </p><ul style=3D"list-style: none; padding: 0;"><li style=3D"margin: 0; pad= ding: 0;"><p>File CMakeLists=2Etxt:</p><ul style=3D"list-style: none; paddi= ng: 0;"><li style=3D"margin: 0; padding: 0 0 0 16px;"><p style=3D"margin-bo= ttom: 4px;"><a href=3D"http://gerrit=2Eopenvpn=2Enet/c/openvpn/+/31/comment= /9105e2b1_f784d6bb?usp=3Demail">Patch Set #28, Line 801:</a> <code style=3D= "font-family:monospace,monospace"> target_compile_definitions(test_crypt= o PRIVATE PREFER_OPENSSL_SIPHASH)</code></p><p><blockquote style=3D"border-= left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Does this still do = anything?</blockquote></p><p class=3D"blocks" style=3D"white-space: pre-wra= p; word-wrap: break-word;">Done</p></li></ul></li><li style=3D"margin: 0; p= adding: 0;"><p>File tests/unit_tests/openvpn/Makefile=2Eam:</p><ul style=3D= "list-style: none; padding: 0;"><li style=3D"margin: 0; padding: 0 0 0 16px= ;"><p style=3D"margin-bottom: 4px;"><a href=3D"http://gerrit=2Eopenvpn=2Ene= t/c/openvpn/+/31/comment/13bc8e15_e9fb0f81?usp=3Demail">Patch Set #28, Line= 102:</a> <code style=3D"font-family:monospace,monospace"> -DPREFER_OPENSSL= _SIPHASH \</code></p><p><blockquote style=3D"border-left: 1px solid #aaa; m= argin: 10px 0; padding: 0 10px;">Does this still do anything?</blockquote><= /p><p class=3D"blocks" style=3D"white-space: pre-wrap; word-wrap: break-wor= d;">Done</p></li></ul></li><li style=3D"margin: 0; padding: 0;"><p>File tes= ts/unit_tests/openvpn/siphash_openssl=2Eh:</p><ul style=3D"list-style: none= ; padding: 0;"><li style=3D"margin: 0; padding: 0 0 0 16px;"><p style=3D"ma= rgin-bottom: 4px;"><a href=3D"http://gerrit=2Eopenvpn=2Enet/c/openvpn/+/31/= comment/c2a5f74c_9ec317f0?usp=3Demail">Patch Set #28, Line 2:</a> <code sty= le=3D"font-family:monospace,monospace"> * SipHash reference C implementatio= n</code></p><p><blockquote style=3D"border-left: 1px solid #aaa; margin: 10= px 0; padding: 0 10px;">Wrong copyright header</blockquote></p><p class=3D"= blocks" style=3D"white-space: pre-wrap; word-wrap: break-word;">Done</p></l= i></ul></li><li style=3D"margin: 0; padding: 0;"><p>File tests/unit_tests/o= penvpn/siphash_openssl=2Ec:</p><ul style=3D"list-style: none; padding: 0;">= <li style=3D"margin: 0; padding: 0 0 0 16px;"><p style=3D"margin-bottom: 4p= x;"><a href=3D"http://gerrit=2Eopenvpn=2Enet/c/openvpn/+/31/comment/e652f08= a_7890d92e?usp=3Demail">Patch Set #28, Line 35:</a> <code style=3D"font-fam= ily:monospace,monospace"> * implementation, so we only use for unit testing= that our impelmentation</code></p><p><blockquote style=3D"border-left: 1px= solid #aaa; margin: 10px 0; padding: 0 10px;">"use it" [=E2=80= =A6]</blockquote></p><p class=3D"blocks" style=3D"white-space: pre-wrap; wo= rd-wrap: break-word;">Done</p></li></ul></li></ul><p>To view, visit <a href= =3D"http://gerrit=2Eopenvpn=2Enet/c/openvpn/+/31?usp=3Demail">change 31</a>= =2E To unsubscribe, or for help writing mail filters, visit <a href=3D"http= ://gerrit=2Eopenvpn=2Enet/settings?usp=3Demail">settings</a>=2E</p><div ite= mscope itemtype=3D"http://schema=2Eorg/EmailMessage"><div itemscope itempro= p=3D"action" itemtype=3D"http://schema=2Eorg/ViewAction"><link itemprop=3D"= url" href=3D"http://gerrit=2Eopenvpn=2Enet/c/openvpn/+/31?usp=3Demail"/><me= ta itemprop=3D"name" content=3D"View Change"/></div></div> <div style=3D"d= isplay:none"> Gerrit-MessageType: comment </div> <div style=3D"display:none= "> Gerrit-Project: openvpn </div> <div style=3D"display:none"> Gerrit-Branc= h: master </div> <div style=3D"display:none"> Gerrit-Change-Id: I09aa27caa1= a3aab0d1be6118b26d54a1c1bf7aa0 </div> <div style=3D"display:none"> Gerrit-C= hange-Number: 31 </div> <div style=3D"display:none"> Gerrit-PatchSet: 30 </= div> <div style=3D"display:none"> Gerrit-Owner: plaisthos <arne-openvpn@= rfc2549=2Eorg> </div> <div style=3D"display:none"> Gerrit-Reviewer: flic= htenheld <frank@lichtenheld=2Ecom> </div> <div style=3D"display:none"= > Gerrit-CC: openvpn-devel <openvpn-devel@lists=2Esourceforge=2Enet> = </div> <div style=3D"display:none"> Gerrit-Attention: plaisthos <arne-op= envpn@rfc2549=2Eorg> </div> <div style=3D"display:none"> Gerrit-Comment-= Date: Thu, 30 Jul 2026 18:23:45 +0000 </div> <div style=3D"display:none"> G= errit-HasComments: Yes </div> <div style=3D"display:none"> Gerrit-Has-Label= s: Yes </div> <div style=3D"display:none"> Comment-In-Reply-To: flichtenhel= d <frank@lichtenheld=2Ecom> </div> </body></html> --7zNF1HjOYtk=-- --===============4344579062079425623== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline --===============4344579062079425623== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel --===============4344579062079425623==--