[Openvpn-devel] [M] Change in openvpn[master]: Add aws-lc siphash implementation
"flichtenheld \(Code Review\) via Openvpn-devel" <[email protected]> Thu, 30 Jul 2026 18:27:42 +0000
| Newsgroups | net.sourceforge.lists.openvpn-devel |
|---|---|
| Message-ID | <b6e44cbd776eb7e213e327675ca1bb50d6f13af2-EmailReviewComments-HTML@gerrit.openvpn.net> |
--===============6048708133812400585== Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="Of2aIeNNA5c="; charset=UTF-8 --Of2aIeNNA5c= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos=2E flichtenheld has posted= comments on this change by plaisthos=2E ( http://gerrit=2Eopenvpn=2Enet/c/= openvpn/+/1572?usp=3Demail ) Change subject: Add aws-lc siphash implementa= tion =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E Patch = Set 24: Code-Review+2 (1 comment) File src/openvpn/siphash=2Eh: http://g= errit=2Eopenvpn=2Enet/c/openvpn/+/1572/comment/840e5c22_91b66536?usp=3Demai= l : PS21, Line 57: return 0; > I removed the return type as we no longe= r use OpenSSL and the other two implementation cannot fail a [=E2=80=A6] Do= ne -- To view, visit http://gerrit=2Eopenvpn=2Enet/c/openvpn/+/1572?usp= =3Demail To unsubscribe, or for help writing mail filters, visit http://ger= rit=2Eopenvpn=2Enet/settings?usp=3Demail Gerrit-MessageType: comment Gerri= t-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I05e20f8c82494e4= abf96fe1e3a73e1c7b9101af6 Gerrit-Change-Number: 1572 Gerrit-PatchSet: 24 Ge= rrit-Owner: plaisthos <arne-openvpn@rfc2549=2Eorg> Gerrit-Reviewer: flichte= nheld <frank@lichtenheld=2Ecom> Gerrit-CC: openvpn-devel <openvpn-devel@lis= ts=2Esourceforge=2Enet> Gerrit-Attention: plaisthos <arne-openvpn@rfc2549= =2Eorg> Gerrit-Comment-Date: Thu, 30 Jul 2026 18:27:42 +0000 Gerrit-HasComm= ents: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: plaisthos <arne-openv= pn@rfc2549=2Eorg> Comment-In-Reply-To: flichtenheld <frank@lichtenheld=2Eco= m> --Of2aIeNNA5c= Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable <!DOCTYPE html><html><head><style></style></head><body><p> Attention is cur= rently required from: plaisthos=2E </p> <p>Patch set 24:<span style=3D"bord= er-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;backgrou= nd-color: #d4ffd4;">Code-Review +2</span></p><p><a href=3D"http://gerrit=2E= openvpn=2Enet/c/openvpn/+/1572?usp=3Demail">View Change</a></p><p>1 comment= :</p><ul style=3D"list-style: none; padding: 0;"><li style=3D"margin: 0; pa= dding: 0;"><p>File src/openvpn/siphash=2Eh:</p><ul style=3D"list-style: non= e; padding: 0;"><li style=3D"margin: 0; padding: 0 0 0 16px;"><p style=3D"m= argin-bottom: 4px;"><a href=3D"http://gerrit=2Eopenvpn=2Enet/c/openvpn/+/15= 72/comment/840e5c22_91b66536?usp=3Demail">Patch Set #21, Line 57:</a> <code= style=3D"font-family:monospace,monospace"> return 0;</code></p><p><bloc= kquote style=3D"border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10p= x;">I removed the return type as we no longer use OpenSSL and the other two= implementation cannot fail a [=E2=80=A6]</blockquote></p><p class=3D"block= s" style=3D"white-space: pre-wrap; word-wrap: break-word;">Done</p></li></u= l></li></ul><p>To view, visit <a href=3D"http://gerrit=2Eopenvpn=2Enet/c/op= envpn/+/1572?usp=3Demail">change 1572</a>=2E To unsubscribe, or for help wr= iting mail filters, visit <a href=3D"http://gerrit=2Eopenvpn=2Enet/settings= ?usp=3Demail">settings</a>=2E</p><div itemscope itemtype=3D"http://schema= =2Eorg/EmailMessage"><div itemscope itemprop=3D"action" itemtype=3D"http://= schema=2Eorg/ViewAction"><link itemprop=3D"url" href=3D"http://gerrit=2Eope= nvpn=2Enet/c/openvpn/+/1572?usp=3Demail"/><meta itemprop=3D"name" content= =3D"View Change"/></div></div> <div style=3D"display:none"> Gerrit-Message= Type: comment </div> <div style=3D"display:none"> Gerrit-Project: openvpn <= /div> <div style=3D"display:none"> Gerrit-Branch: master </div> <div style= =3D"display:none"> Gerrit-Change-Id: I05e20f8c82494e4abf96fe1e3a73e1c7b9101= af6 </div> <div style=3D"display:none"> Gerrit-Change-Number: 1572 </div> <= div style=3D"display:none"> Gerrit-PatchSet: 24 </div> <div style=3D"displa= y:none"> Gerrit-Owner: plaisthos <arne-openvpn@rfc2549=2Eorg> </div> = <div style=3D"display:none"> Gerrit-Reviewer: flichtenheld <frank@lichte= nheld=2Ecom> </div> <div style=3D"display:none"> Gerrit-CC: openvpn-deve= l <openvpn-devel@lists=2Esourceforge=2Enet> </div> <div style=3D"disp= lay:none"> Gerrit-Attention: plaisthos <arne-openvpn@rfc2549=2Eorg> <= /div> <div style=3D"display:none"> Gerrit-Comment-Date: Thu, 30 Jul 2026 18= :27:42 +0000 </div> <div style=3D"display:none"> Gerrit-HasComments: Yes </= div> <div style=3D"display:none"> Gerrit-Has-Labels: Yes </div> <div style= =3D"display:none"> Comment-In-Reply-To: plaisthos <arne-openvpn@rfc2549= =2Eorg> </div> <div style=3D"display:none"> Comment-In-Reply-To: flichte= nheld <frank@lichtenheld=2Ecom> </div> </body></html> --Of2aIeNNA5c=-- --===============6048708133812400585== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline --===============6048708133812400585== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel --===============6048708133812400585==--